Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeview multiselect is flakey #211465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Treeview multiselect is flakey #211465

wants to merge 1 commit into from

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Apr 26, 2024

Fixes #208802

@alexr00 alexr00 requested a review from joaomoreno April 26, 2024 15:26
@alexr00 alexr00 self-assigned this Apr 26, 2024
@alexr00 alexr00 enabled auto-merge (squash) April 26, 2024 15:26
Copy link
Member Author

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rerender comes from here:

this.treeDisposables.add(treeMenus.onDidChange((changed) => {
if (this.tree?.hasNode(changed)) {
this.tree?.rerender(changed);
}
}));

That event is fired when the menu that has the inline actions has it's context change, which is expected to happen during multiselect.

@VSCodeTriageBot VSCodeTriageBot added this to the April 2024 milestone Apr 26, 2024
@lramos15 lramos15 modified the milestones: April 2024, May 2024 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treeview multiselect is flakey
3 participants