update FindFiles2 to make options clearer #211494
Conversation
| export enum SearchIgnoreOptions { | ||
| none = 1, | ||
| localOnly = 2, | ||
| localAndFollowSettings = 3, |
There was a problem hiding this comment.
Which settings? does followSettings means to follow what's set in excludeSettingOptions?
There was a problem hiding this comment.
This means to follow the settings for global and parent ignore files-following. So using those settings to dictate whether to use them.
There was a problem hiding this comment.
Could the option be changed to followIgnoreSettings or a note be added to the docstring then? Otherwise, I think it's really easy to mix up these followSettings keys with the exclude enum options and/or exclude settings.
There was a problem hiding this comment.
Do you think that option 2 in this comment makes anything more clear? #205692 (comment)
There was a problem hiding this comment.
Although this PR has the enum approach, I've been brainstorming better ways to go about this.
Fixes #205692
Edits the FindFiles2 API to be clearer in the exclude/ignore behavior.