[TEST] Randomized number of replicas between 0 and the number of data…

… nodes - 1 (rather than just between 0 and 1) Closes elastic#5896
mikemccand · Apr 24, 2014 · d334845 · d334845
1 parent 598420f
commit d334845
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/test/java/org/elasticsearch/test/ImmutableTestCluster.java b/src/test/java/org/elasticsearch/test/ImmutableTestCluster.java
@@ -20,6 +20,7 @@
 package org.elasticsearch.test;
 
 import com.carrotsearch.hppc.ObjectArrayList;
+import com.carrotsearch.randomizedtesting.RandomizedTest;
 import com.carrotsearch.randomizedtesting.generators.RandomInts;
 import com.carrotsearch.randomizedtesting.generators.RandomPicks;
 import org.apache.lucene.store.StoreRateLimiting;
@@ -156,7 +157,7 @@ public void wipeIndices(String... indices) {
                 // which is the case in the CloseIndexDisableCloseAllTests
                 if ("_all".equals(indices[0])) {
                     ClusterStateResponse clusterStateResponse = client().admin().cluster().prepareState().execute().actionGet();
-                    ObjectArrayList<String> concreteIndices = new ObjectArrayList<String>();
+                    ObjectArrayList<String> concreteIndices = new ObjectArrayList<>();
                     for (IndexMetaData indexMetaData : clusterStateResponse.getState().metaData()) {
                         concreteIndices.add(indexMetaData.getIndex());
                     }
@@ -234,8 +235,8 @@ public void randomIndexTemplate() {
                     setRandomSettings(random, ImmutableSettings.builder())
                     .put(SETTING_INDEX_SEED, random.nextLong())
                     .put(SETTING_NUMBER_OF_SHARDS, RandomInts.randomIntBetween(random, DEFAULT_MIN_NUM_SHARDS, DEFAULT_MAX_NUM_SHARDS))
-                    .put(SETTING_NUMBER_OF_REPLICAS, RandomInts.randomIntBetween(random, 0, 1));
-
+                    //use either 0 or 1 replica, yet a higher amount when possible, but only rarely
+                    .put(SETTING_NUMBER_OF_REPLICAS, RandomInts.randomIntBetween(random, 0, random.nextInt(10) > 0 ? 1 : dataNodes() - 1));
             client().admin().indices().preparePutTemplate("random_index_template")
                     .setTemplate("*")
                     .setOrder(0)