Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Project added in "Projects" menu #1011

Closed
wants to merge 3 commits into from

Conversation

ColinTree
Copy link
Contributor

@ColinTree ColinTree commented Nov 18, 2017

Related: #905

image
image
image

@ewpatton
Copy link
Member

@ColinTree I'm wondering if there is a more effective way of doing this. Right now this will duplicate all of the entities and then deletes them. Since we pay for every data store operation it would be better to rename/update the existing entities.

@ewpatton ewpatton mentioned this pull request Nov 18, 2017
@ColinTree
Copy link
Contributor Author

I had tried to change the projectName successfully, but it is only on the server.
At this point, the client would not load the new project correctly until the whole webpage is refreshed, because the project name is cached everywhere, like in the ProjectNodes.
Unless a big change is maded, we still needs to re-get the project data. So should i make a change on the scructure?

@ColinTree
Copy link
Contributor Author

The currently status of this thread:
all the rename processes are now in one request by explorer, named "rename", and do "copy" and "delete (the old project)" in the server

@AppInventorWorkerBee
Copy link
Collaborator

Can one of the admins verify this patch?

@ColinTree ColinTree deleted the RenameProject-#905 branch March 6, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants