wrap-cookies no longer overwrites any pre-set Set-Cookie headers

mmcgrana · Nov 14, 2010 · d66cf3f · d66cf3f
1 parent 812b240
commit d66cf3f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/ring-core/src/ring/middleware/cookies.clj b/ring-core/src/ring/middleware/cookies.clj
@@ -115,9 +115,10 @@
   "Add a Set-Cookie header to a response if there is a :cookies key."
   [response]
   (if-let [cookies (:cookies response)]
-    (assoc-in response
-              [:headers "Set-Cookie"]
-              (write-cookies cookies))
+    (update-in response
+               [:headers "Set-Cookie"]
+               concat
+               (write-cookies cookies))
     response))
 
 (defn wrap-cookies

diff --git a/ring-core/test/ring/middleware/cookies_test.clj b/ring-core/test/ring/middleware/cookies_test.clj
@@ -71,3 +71,10 @@
         resp    ((wrap-cookies handler) {})]
     (is (= {"Set-Cookie" (list "a=hello+world")}
            (:headers resp)))))
+
+(deftest wrap-cookies-keep-set-cookies-intact
+  (let [handler (constantly {:headers {"Set-Cookie" (list "a=b")}
+                             :cookies {:c "d"}})
+        resp    ((wrap-cookies handler) {})]
+    (is (= {"Set-Cookie" (list "a=b" "c=d")}
+           (:headers resp)))))