Update to use QUnit v1.11.0 and merged in PRs #20, #25 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelhandler
commented
May 6, 2013
pixelhandler
commented
- pixelhandler/master should have all PR's merged in currently on mmonteleone/pavlov
- doesn't make sense to redefine it ourselves
- recommended HTML5 practice (all tests still pass)
- In IE7, current QUnit (v1.9.0pre) injects an <a>nchor into <h1> AFTER pavlov.specify ran, whil in other browsers it injects it BEFORE pavlov.specify. Switching from equals to contains (indexOf) allows the test "should update heading to suite name" to pass in all browsers
Since JsTestDriver does not allow commas in test names this 'quick-n-dirty' fix is required to allow Pavlov to work in a JsTestDriver environment. Note: a more sensible approach would be to fix JsTestDriver to not place restrictions on test names but this seems to be way harder to fix. Signed-off-by: Isak Bakken <isak@klarna.com>
Signed-off-by: Isak Bakken <isak@klarna.com>
Signed-off-by: Isak Bakken <isak@klarna.com>
- both JSHint and JSLint now pass pavlov.js validation
- properly handle both strings and Error objects
- equals and isEqualTo changed from using operator '==' to '==='
- when using 'this' in util.each iterator function, IE boxes numbers into objects (that look like numbers); using function argument instead of this works fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.