Refactor several classes for code readability and upgrade package ver…

…sions

This commit refactors multiple classes in the mobx, flutter_mobx, and mobx_example libraries to simplify and improve parameter passing. It also upgrades the versions of mobx and flutter_mobx packages. JSON serialization behaviour in the Todo List example of mobx_example is updated to exclude certain attributes from toJSON and fromJSON methods.

flutter_mobx/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.2.1+1
+
+- Analyzer fixes
+
 ## 2.2.1
 
 - Upgrading packages and sdk

flutter_mobx/lib/src/multi_reaction_builder.dart

@@ -50,8 +50,8 @@ import 'package:provider/provider.dart';
 class MultiReactionBuilder extends MultiProvider {
   /// {@macro multi_reaction_builder}
   MultiReactionBuilder({
-    Key? key,
+    super.key,
     required List<ReactionBuilder> builders,
-    required Widget child,
-  }) : super(key: key, providers: builders, child: child);
+    required Widget super.child,
+  }) : super(providers: builders);
 }

flutter_mobx/lib/src/observer.dart

@@ -19,36 +19,26 @@ bool debugAddStackTraceInObserverName = true;
 class Observer extends StatelessObserverWidget {
   // ignore: prefer_const_constructors_in_immutables
   Observer({
-    Key? key,
+    super.key,
     required this.builder,
-    String? name,
-    bool? warnWhenNoObservables,
+    super.name,
+    super.warnWhenNoObservables,
   })  : debugConstructingStackFrame = debugFindConstructingStackFrame(),
         builderWithChild = null,
         child = null,
-        assert(builder != null),
-        super(
-          key: key,
-          name: name,
-          warnWhenNoObservables: warnWhenNoObservables,
-        );
+        assert(builder != null);
 
   /// Observer which excludes the child branch from being rebuilt
   // ignore: prefer_const_constructors_in_immutables
   Observer.withBuiltChild({
-    Key? key,
+    super.key,
     required this.builderWithChild,
     required this.child,
-    String? name,
-    bool? warnWhenNoObservables,
+    super.name,
+    super.warnWhenNoObservables,
   })  : debugConstructingStackFrame = debugFindConstructingStackFrame(),
         builder = null,
-        assert(builderWithChild != null && child != null),
-        super(
-          key: key,
-          name: name,
-          warnWhenNoObservables: warnWhenNoObservables,
-        );
+        assert(builderWithChild != null && child != null);
 
   /// regular builder, suitable for most cases
   final WidgetBuilder? builder;

flutter_mobx/lib/src/reaction_builder.dart

@@ -20,8 +20,7 @@ typedef ReactionBuilderFunction = ReactionDisposer Function(
 class ReactionBuilder extends SingleChildStatefulWidget {
   final ReactionBuilderFunction builder;
 
-  const ReactionBuilder({Key? key, Widget? child, required this.builder})
-      : super(key: key, child: child);
+  const ReactionBuilder({super.key, super.child, required this.builder});
 
   @override
   ReactionBuilderState createState() => ReactionBuilderState();

flutter_mobx/lib/src/stateful_observer_widget.dart

@@ -14,10 +14,9 @@ abstract class StatefulObserverWidget extends StatefulWidget
     with ObserverWidgetMixin {
   /// Initializes [key], [context] and [name] for subclasses.
   const StatefulObserverWidget(
-      {Key? key, ReactiveContext? context, String? name})
+      {super.key, ReactiveContext? context, String? name})
       : _name = name,
-        _context = context,
-        super(key: key);
+        _context = context;
 
   final String? _name;
   final ReactiveContext? _context;
@@ -36,7 +35,7 @@ abstract class StatefulObserverWidget extends StatefulWidget
 class StatefulObserverElement extends StatefulElement
     with ObserverElementMixin {
   /// Creates an element that uses the given widget as its configuration.
-  StatefulObserverElement(StatefulObserverWidget widget) : super(widget);
+  StatefulObserverElement(StatefulObserverWidget super.widget);
 
   @override
   StatefulObserverWidget get widget => super.widget as StatefulObserverWidget;

flutter_mobx/lib/src/stateless_observer_widget.dart

@@ -14,13 +14,12 @@ abstract class StatelessObserverWidget extends StatelessWidget
     with ObserverWidgetMixin {
   /// Initializes [key], [context] and [name] for subclasses.
   const StatelessObserverWidget({
-    Key? key,
+    super.key,
     ReactiveContext? context,
     String? name,
     this.warnWhenNoObservables,
   })  : _name = name,
-        _context = context,
-        super(key: key);
+        _context = context;
 
   final String? _name;
   final ReactiveContext? _context;
@@ -41,7 +40,7 @@ abstract class StatelessObserverWidget extends StatelessWidget
 class StatelessObserverElement extends StatelessElement
     with ObserverElementMixin {
   /// Creates an element that uses the given widget as its configuration.
-  StatelessObserverElement(StatelessObserverWidget widget) : super(widget);
+  StatelessObserverElement(StatelessObserverWidget super.widget);
 
   @override
   StatelessObserverWidget get widget => super.widget as StatelessObserverWidget;

flutter_mobx/lib/version.dart

@@ -1,4 +1,4 @@
 // Generated via set_version.dart. !!!DO NOT MODIFY BY HAND!!!
 
 /// The current version as per `pubspec.yaml`.
-const version = '2.2.1';
+const version = '2.2.1+1';

flutter_mobx/pubspec.yaml

@@ -2,7 +2,7 @@ name: flutter_mobx
 description:
   Flutter integration for MobX. It provides a set of Observer widgets that automatically rebuild
   when the tracked observables change.
-version: 2.2.1
+version: 2.2.1+1
 
 repository: https://github.com/mobxjs/mobx.dart
 issue_tracker: https://github.com/mobxjs/mobx.dart/issues

flutter_mobx/test/flutter_mobx_test.dart

@@ -419,7 +419,7 @@ Future<_ErrorWrapper> _testThrowingObserverWithStackTrace(
 
 class ConstObserver extends StatelessObserverWidget {
   // const keyword compiles
-  const ConstObserver({Key? key}) : super(key: key);
+  const ConstObserver({super.key});
 
   @override
   Widget build(BuildContext context) => Container();
@@ -430,7 +430,7 @@ class ConstObserver extends StatelessObserverWidget {
 
 class ConstStatefulObserver extends StatefulObserverWidget {
   // const keyword compiles
-  const ConstStatefulObserver({Key? key}) : super(key: key);
+  const ConstStatefulObserver({super.key});
 
   @override
   State<ConstStatefulObserver> createState() => _ConstStatefulObserverState();
@@ -442,7 +442,7 @@ class _ConstStatefulObserverState extends State<ConstStatefulObserver> {
 }
 
 class _ObserverRebuildTestMyApp extends StatefulWidget {
-  const _ObserverRebuildTestMyApp({Key? key}) : super(key: key);
+  const _ObserverRebuildTestMyApp();
 
   @override
   State<_ObserverRebuildTestMyApp> createState() =>
@@ -471,8 +471,7 @@ class _ObserverRebuildTestMyAppState extends State<_ObserverRebuildTestMyApp> {
 class _ObserverRebuildTestOne extends StatelessWidget {
   final _ObserverRebuildTestMyStore store;
 
-  const _ObserverRebuildTestOne({Key? key, required this.store})
-      : super(key: key);
+  const _ObserverRebuildTestOne({required this.store});
 
   @override
   Widget build(BuildContext context) {
@@ -494,8 +493,7 @@ class _ObserverRebuildTestOne extends StatelessWidget {
 class _ObserverRebuildTestTwo extends StatelessWidget {
   final _ObserverRebuildTestMyStore store;
 
-  const _ObserverRebuildTestTwo({Key? key, required this.store})
-      : super(key: key);
+  const _ObserverRebuildTestTwo({required this.store});
 
   @override
   Widget build(BuildContext context) {
@@ -512,8 +510,7 @@ class _ObserverRebuildTestTwo extends StatelessWidget {
 class _ObserverRebuildTestTwoChild extends StatefulWidget {
   final _ObserverRebuildTestMyStore store;
 
-  const _ObserverRebuildTestTwoChild({Key? key, required this.store})
-      : super(key: key);
+  const _ObserverRebuildTestTwoChild({required this.store});
 
   @override
   _ObserverRebuildTestTwoChildState createState() =>

flutter_mobx/test/helpers.dart

@@ -21,8 +21,7 @@ class MockReaction extends Mock implements ReactionImpl {
 
 // ignore: must_be_immutable
 class TestObserver extends Observer {
-  TestObserver(this.reaction, {Key? key, required WidgetBuilder builder})
-      : super(builder: builder, key: key);
+  TestObserver(this.reaction, {super.key, required WidgetBuilder super.builder});
 
   final Reaction reaction;
 
@@ -38,14 +37,10 @@ class TestObserver extends Observer {
 class LoggingObserver extends Observer {
   // ignore: prefer_const_constructors_in_immutables
   LoggingObserver({
-    required WidgetBuilder builder,
-    bool? warnWhenNoObservables,
-    Key? key,
-  }) : super(
-          key: key,
-          builder: builder,
-          warnWhenNoObservables: warnWhenNoObservables,
-        );
+    required WidgetBuilder super.builder,
+    super.warnWhenNoObservables,
+    super.key,
+  });
 
   String? previousLog;
 
@@ -59,10 +54,10 @@ class LoggingObserver extends Observer {
 class FlutterErrorThrowingObserver extends Observer {
   // ignore: prefer_const_constructors_in_immutables
   FlutterErrorThrowingObserver({
-    required WidgetBuilder builder,
+    required WidgetBuilder super.builder,
     required this.errorToThrow,
-    Key? key,
-  }) : super(key: key, builder: builder);
+    super.key,
+  });
 
   final Object errorToThrow;
 
@@ -72,8 +67,7 @@ class FlutterErrorThrowingObserver extends Observer {
 }
 
 class FlutterErrorThrowingObserverElement extends StatelessObserverElement {
-  FlutterErrorThrowingObserverElement(StatelessObserverWidget widget)
-      : super(widget);
+  FlutterErrorThrowingObserverElement(super.widget);
 
   @override
   FlutterErrorThrowingObserver get widget =>

flutter_mobx/test/reaction_builder_test.dart

@@ -6,7 +6,7 @@ import 'package:mobx/mobx.dart';
 class _TestWrapper extends StatefulWidget {
   final Observable<int> counter;
 
-  const _TestWrapper({Key? key, required this.counter}) : super(key: key);
+  const _TestWrapper({required this.counter});
 
   @override
   State<_TestWrapper> createState() => _TestWrapperState();

mobx/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.3.3+1
+
+- Analyzer fixes
+
 ## 2.3.3
 
 - Upgrading packages and sdk

mobx/lib/src/api/annotations.dart

@@ -1,5 +1,6 @@
 /// Declares configuration of a Store class.
 /// Currently the only configuration used is boolean to indicate generation of toString method (true), or not (false)
+library;
 
 class StoreConfig {
   const StoreConfig({this.hasToString = true});

mobx/lib/src/core.dart

@@ -47,7 +47,7 @@ class MobXException extends Error implements Exception {
 /// This exception would be fired when an reaction has a cycle and does
 /// not stabilize in [ReactiveConfig.maxIterations] iterations
 class MobXCyclicReactionException extends MobXException {
-  MobXCyclicReactionException(String message) : super(message);
+  MobXCyclicReactionException(super.message);
 }
 
 /// This captures the stack trace when user-land code throws an exception

mobx/lib/src/core/computed.dart

@@ -43,10 +43,10 @@ class Computed<T> extends Atom implements Derivation, ObservableValue<T> {
       Computed._(context ?? mainContext, fn,
           name: name, equals: equals, keepAlive: keepAlive);
 
-  Computed._(ReactiveContext context, this._fn,
+  Computed._(super.context, this._fn,
       {String? name, this.equals, bool? keepAlive})
       : _keepAlive = keepAlive ?? false,
-        super._(context, name: name ?? context.nameFor('Computed'));
+        super._(name: name ?? context.nameFor('Computed'));
 
   final EqualityComparer<T>? equals;
 

mobx/lib/src/core/observable.dart

@@ -28,11 +28,11 @@ class Observable<T> extends Atom
       Observable._(context ?? mainContext, initialValue,
           name: name, equals: equals);
 
-  Observable._(ReactiveContext context, this._value,
+  Observable._(super.context, this._value,
       {String? name, this.equals})
       : _interceptors = Interceptors(context),
         _listeners = Listeners(context),
-        super._(context, name: name ?? context.nameFor('Observable')) {
+        super._(name: name ?? context.nameFor('Observable')) {
     if (_context.isSpyEnabled) {
       _context.spyReport(ObservableValueSpyEvent(this,
           newValue: _value, name: this.name, isEnd: true));

mobx/lib/src/core/spy.dart

@@ -39,10 +39,9 @@ abstract class SpyEvent {
 
 /// Used for reporting value changes on an Observable
 class ObservableValueSpyEvent extends SpyEvent {
-  ObservableValueSpyEvent(dynamic object,
-      {this.newValue, this.oldValue, required String name, bool isEnd = false})
-      : super._(object,
-            type: 'observable', name: name, isStart: true, isEnd: isEnd);
+  ObservableValueSpyEvent(super.object,
+      {this.newValue, this.oldValue, required super.name, super.isEnd})
+      : super._(type: 'observable', isStart: true);
 
   final dynamic newValue;
   final dynamic oldValue;
@@ -52,9 +51,8 @@ class ObservableValueSpyEvent extends SpyEvent {
 }
 
 class ComputedValueSpyEvent extends SpyEvent {
-  ComputedValueSpyEvent(object, {required String name})
-      : super._(object,
-            type: 'computed', name: name, isStart: true, isEnd: true);
+  ComputedValueSpyEvent(super.object, {required super.name})
+      : super._(type: 'computed', isStart: true, isEnd: true);
 }
 
 class ReactionSpyEvent extends SpyEvent {

mobx/lib/src/interceptable.dart

@@ -14,7 +14,7 @@ abstract class Interceptable<T> {
 /// is stored inside the `Interceptors<T>`.
 /// This is an internal class and should not be used directly.
 class Interceptors<T> extends NotificationHandlers<WillChangeNotification<T>> {
-  Interceptors(ReactiveContext context) : super(context);
+  Interceptors(super.context);
 
   @override
   Dispose add(Interceptor<T> handler) => super.add(handler);

mobx/lib/src/listenable.dart

@@ -11,7 +11,7 @@ abstract class Listenable<TNotification> {
 /// Stores the handler functions that have been attached via [Observable.observe] method
 /// This is an internal class and should not be used directly.
 class Listeners<TNotification> extends NotificationHandlers<TNotification> {
-  Listeners(ReactiveContext context) : super(context);
+  Listeners(super.context);
 
   @override
   Dispose add(Listener<TNotification> handler) => super.add(handler);

mobx/lib/version.dart

@@ -1,4 +1,4 @@
 // Generated via set_version.dart. !!!DO NOT MODIFY BY HAND!!!
 
 /// The current version as per `pubspec.yaml`.
-const version = '2.3.3';
+const version = '2.3.3+1';

mobx/pubspec.yaml

@@ -1,5 +1,5 @@
 name: mobx
-version: 2.3.3
+version: 2.3.3+1
 description: "MobX is a library for reactively managing the state of your applications. Use the power of observables, actions, and reactions to supercharge your Dart and Flutter apps."
 
 repository: https://github.com/mobxjs/mobx.dart

mobx/test/autorun_test.dart

@@ -80,7 +80,7 @@ void main() {
       fakeAsync((async) {
         dispose = autorun((_) {
           value = x.value + 1;
-        }, delay: delayMs);
+        }, delay: delayMs).call;
 
         async.elapse(const Duration(milliseconds: 2500));
 

mobx/test/observable_map_test.dart

@@ -93,7 +93,7 @@ void main() {
       <String, void Function(ObservableMap<String, int>)>{
         '[]': (m) => m['a'],
         'containsKey': (m) => m.containsKey('a'),
-        'containsValue': (m) => m.containsKey(1),
+        'containsValue': (m) => m.containsValue(1),
         'forEach': (m) => m.forEach((_, __) {}),
         'putIfAbsent': (m) => m.putIfAbsent('a', () => 1),
         'length': (m) => m.length,

mobx_examples/lib/hackernews/news_widgets.dart

@@ -67,9 +67,9 @@ class FeedItemsView extends StatelessWidget {
 
         switch (future.status) {
           case FutureStatus.pending:
-            return Column(
+            return const Column(
               mainAxisAlignment: MainAxisAlignment.center,
-              children: const [
+              children: [
                 CircularProgressIndicator(),
                 Text('Loading items...'),
               ],