Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 15.04, add systemd note for 15.04 #14217

Merged
merged 1 commit into from Jul 22, 2015
Merged

Add support for 15.04, add systemd note for 15.04 #14217

merged 1 commit into from Jul 22, 2015

Conversation

ankushagarwal
Copy link
Contributor

Fixes #12002

Signed-off-by: Ankush Agarwal ankushagarwal11@gmail.com

@ankushagarwal
Copy link
Contributor Author

CC @moxiegirl @thaJeztah @jfrazelle

@Jean85
Copy link

Jean85 commented Jul 3, 2015

There's a typo: "installtion".
Can't fix it myself...

@thaJeztah
Copy link
Member

There's a typo: "installtion".

Yes, I noticed that one, thanks @Jean85 ! (also saw a stray   in there)

@thaJeztah
Copy link
Member

@ankushagarwal sorry for not responding to this PR sooner, I actually had this open for a couple of days because I wasn't sure how to proceed here (I did notice the typos, but that's not the main issue).

Because I don't have a clear answer now, I'll just put my thoughts here, perhaps you can think along;

  • I agree this needs to be mentioned somewhere; some people expect that docker is automatically configured to start at boot (when using Systemd). (this was a deliberate decision, so that the user can decide wether or not docker should start automatically)
  • Perhaps we should add a message to the installer that mentions that Docker is not configured to start automatically (just as the "using Docker as non-root" message in the installer)
  • It's a bit strange that this section describes how to handle automatic start after installing on 15.04, but there's no actual installation procedure / mention of 15.04 in the document. In fact, it's not mentioned below "Docker is supported on these Ubuntu operating systems:".
  • There's also sections on systemd and host integration that can be relevant here, perhaps this should be put inside that document?

(I also think the section on 13.10 should be removed, because it doesn't really add anything and 13.10 is end-of-life as of July 2014, but that's unrelated here 😄)

/cc @moxiegirl (we briefly discussed this on IRC)

@ankushagarwal
Copy link
Contributor Author

I strongly believe that docker starting up on boot should be default behaviour regardless of the package manager or the system manager or the distro you are trying to install docker on and this behaviour should not differ from distro to distro or package manager or the system manager (systemd v/s upstart). On completing installation we can print a message saying something like "docker will start on boot.... Run command xyz to turn off docker starting on boot..."

I believe so because most system softwares are installed with expectation to start on bootup. Most systems softwares are daemons (eg: sshd, crond, etc) and are always expected to run in the background without explicitly configuring them to do so.

The only reason I see why people wouldn't want docker to start on startup would be if they are experimenting with docker on their laptops. But I believe anybody trying to install docker on a server or a VM would want auto restart on boot as default behavior, with an easily configurable option to disable that.

People have been using wget -qO- https://get.docker.com/ | sh for a while and nobody has complained about docker automatically starting on boot, but started complaining when they did not see that behaviour.

@ankushagarwal
Copy link
Contributor Author

Regarding the 15.04 comment, can we just update the docs and say we support 14.04 and above?

@moxiegirl
Copy link
Contributor

@ankushagarwal I don't think anyone disagrees that docker daemon should be started on boot. With this contribution, there are two aspects here.

  • Adding messaging to the installer which is suggested but not implemented in this ticket
  • Inclusion of the systemd startup material in the installation docs and in other places

We are leaning toward consolidating the material regarding configuration of startup options in another page. This page is becoming the central location for that https://docs.docker.com/articles/systemd/ . It covers something a bit further than starting the daemon which is also useful. Maybe you can consider adding your information to that page.

And then, we will need a link from each installation out to that which I will do. What do you think?

RE the version support, we should just confirm with the tech team before imparting that information. @icecrime for the support of 15.04 on Ubuntu

@icecrime
Copy link
Contributor

icecrime commented Jul 7, 2015

Installation is not specific to a given Ubuntu version, unfortunately administration is (as 15.04 introduced systemd). That being said, yes 15.04 is obviously supported, and indeed this could get a bit of a refresh: http://docs.docker.com/installation/ubuntulinux/#ubuntu

@ankushagarwal
Copy link
Contributor Author

Sounds good. Will update the article to reflect that.

@moxiegirl
Copy link
Contributor

Thanks @icecrime and @ankushagarwal.

@thaJeztah
Copy link
Member

Thanks! I'd be +1 to mention support for the LTS releases (12.04, 14.04) separate from the "regular" releases, so not mention "14.04 and above". IIRC, 14.10 had some issues running docker and (being a non-LTS release), is no longer supported; http://fridge.ubuntu.com/2015/07/03/ubuntu-14-10-utopic-unicorn-reaches-end-of-life-on-july-23-2015/

So we should keep a good eye on those releases, and keep them up-to-date at all times (and make a mention of that?)

@ankushagarwal
Copy link
Contributor Author

Makes sense. I'll make sure I'll take that into account.

@cpuguy83
Copy link
Member

Is this one ready?

@ankushagarwal
Copy link
Contributor Author

I'll update this by tomorrow.

@ankushagarwal
Copy link
Contributor Author

Patch updated.
Could you guys please review : @thaJeztah @icecrime @cpuguy83 @moxiegirl

Fixes #12002

Signed-off-by: Ankush Agarwal <ankushagarwal11@gmail.com>
@ankushagarwal ankushagarwal changed the title Add docs to ubuntu regarding startup on boot Add support for 15.04, add systemd note for 15.04 Jul 20, 2015
@jessfraz
Copy link
Contributor

LGTM

@ankushagarwal
Copy link
Contributor Author

@jfrazelle : Is there a plan to do this(sudo systemctl enable docker) automatically in the install script?

@tianon
Copy link
Member

tianon commented Jul 22, 2015 via email

@moxiegirl
Copy link
Contributor

LGTM THANKS @ankushagarwal

moxiegirl pushed a commit that referenced this pull request Jul 22, 2015
Add support for 15.04, add systemd note for 15.04
@moxiegirl moxiegirl merged commit 7d8859a into moby:master Jul 22, 2015
@ankushagarwal ankushagarwal deleted the ubuntu-15.04 branch July 25, 2015 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants