Add Swarm management CLI commands #23363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
the
status/failing-ci
| if !ok { | ||
| return fmt.Errorf("Failed to parse %v as a rational number", value) | ||
| } | ||
| *c = nanoCPUs(cpu.Mul(cpu, big.NewRat(1e9, 1)).Num().Int64()) |
There was a problem hiding this comment.
Before calling Int64(), you have to check IsInt() or return an error. This is to make sure there's no loss (user input is not below nanos).
dnephin
force-pushed
the
swarm-cli
branch
2 times, most recently
from
e631699
to
c32e879
Compare
|
Ok, those issues should be fixed. |
tonistiigi
force-pushed
the
swarm-backend
branch
from
41e877c
to
74371fb
Compare
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "promote NODE [NODE...]", | ||
| Short: "Promote a node as manager in the swarm", |
There was a problem hiding this comment.
Probably, "Promote a node to manager in the swarm"?
|
win2lin error is weird : |
|
@vdemeester it's because that CI is still on Go 1.5.4 |
|
Just let you know, I did a rebase on master with a small conflict at: Other than that it's just fine. |
ghost
mentioned this pull request
As described in our ROADMAP.md, introduce new Swarm management commands to call to the corresponding API endpoints. This PR is fully backward compatible (joining a Swarm is an optional feature of the Engine, and existing commands are not impacted). Signed-off-by: Daniel Nephin <dnephin@docker.com> Signed-off-by: Victor Vieux <vieux@docker.com> Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Rename `--port` to `--publish` for consistency between `docker service` and `docker run`. Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com>
Signed-off-by: Victor Vieux <vieux@docker.com>
Rename `--restart-policy-*` flags to `--restart-*` (e.g., `--restart-policy-delay` becomes `--restart-delay`). Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com>
Rename `--updateconfig-*` to `--update-*` and improve help messages. Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com>
- Set secret when using default policy - Always initialize policy for all roles Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Victor Vieux <vieux@docker.com>
tonistiigi
force-pushed
the
swarm-backend
branch
from
74371fb
to
a7d0b2c
Compare
|
LGTM 💯 |
|
LGTM 💯 |
tonistiigi
removed
the
status/failing-ci
|
LGTM |
|
CLI reference and docs will be completed in a followup 👍 |
|
🎉 🎉 I love the new |
|
🐝 🐝 🎉 |
|
@thaJeztah This PR added reference pages for the |
|
@thaJeztah cool, thanks. I already dropped a note there. |
This was referenced Jun 18, 2016
This was referenced Jul 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in our ROADMAP.md, introduce new Swarm management commands to call to the corresponding API endpoints.
This PR is fully backward compatible (joining a Swarm is an optional feature of the Engine, and existing commands are not impacted)