Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Bump RW layer size #35925

Merged
merged 1 commit into from Jan 5, 2018

Conversation

lowenna
Copy link
Member

@lowenna lowenna commented Jan 4, 2018

Signed-off-by: John Howard jhoward@microsoft.com

@johnstep @darrenstahlmsft As mentioned offline... PTAL

This bumps the size of the RW layer (sandbox.vhdx) from the default (20GB, hard coded in the platform) to 127GB (purely as the default size of a VHD in Hyper-V) for the builder RUN scenario where users are adding a lot of data during a RUN statement (eg while debugging #32838). Done local verification using diskmgmt.msc watching disk being attached/detached to verify it's operating as expected.

image

It does not change the default size for a docker run (which can be controlled anyway through --storage-opt)

@friism FYI.

Signed-off-by: John Howard <jhoward@microsoft.com>
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebolland
Copy link

Is this the first part of a fix for #33586 ?

@lowenna
Copy link
Member Author

lowenna commented Jan 5, 2018

@mikebolland No, that is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants