Fix docker logs hangs after stop container when using journald #39305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
@Vanient journald log driver has lots of issues, some (including docker/for-linux#575) are addressed in #38859, you are more than welcome to give it a review and test. |
|
In particular, the fix for docker/for-linux#575 is here: cd13be8 |
Fix when using journald as log-driver, docker logs -f <containerID> hangs after the container is exited. LogWatcher.WatchProducerGone() returns a channel receiver to receive notification once container is gone. fixes docker/for-linux#575 Signed-off-by: Danni Xia <xiadanni1@huawei.com>
thaJeztah
added
area/logging
status/2-code-review
rebuild/*
and removed
status/0-triage
labels
|
@kolyshkin I see this was updated after your last comment; PTAL |
Codecov Report
@@ Coverage Diff @@
## master #39305 +/- ##
=========================================
Coverage ? 37.05%
=========================================
Files ? 612
Lines ? 45486
Branches ? 0
=========================================
Hits ? 16854
Misses ? 26347
Partials ? 2285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix when using journald as log-driver, docker logs -f hangs
after the container is exited. LogWatcher.WatchProducerGone() returns a
channel receiver to receive notification once container is gone.
fixes docker/for-linux#575
Signed-off-by: Danni Xia xiadanni1@huawei.com
- What I did
fix docker/for-linux#575
- How I did it
Add logWatcher.WatchProducerGone() to receive notification when container is gone.
- How to verify it
docker logs -f $(docker run -d --rm --log-driver journald busybox sh -c "for i in \$(seq 1 10); do echo logline \$i; sleep 1; done")Verify that docker logs process can exit.