Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change expried #250

Merged
merged 1 commit into from
Sep 26, 2023
Merged

change expried #250

merged 1 commit into from
Sep 26, 2023

Conversation

Bournwog
Copy link
Contributor

redis don't accept zero expired

@cla-bot cla-bot bot added the cla-signed CLA confirmed for all contributors to this PR label Mar 30, 2023
@opengeek
Copy link
Member

@Bournwog — thanks for your contribution. Can you provide a little more detail regarding this change?

@Bournwog
Copy link
Contributor Author

Bournwog commented Apr 4, 2023

if we set $expire = 0 in this code (infinity cache), redis throw error because "expire" is zero
$set = $this->redis->set($this->getCacheKey($key),$var,$expire);

@opengeek opengeek merged commit c7226ee into modxcms:3.x Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for all contributors to this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants