es 1.4.0 needs index.version.created in its settings, added parameter to... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to pass settings to typemapping
msparer
added a commit
that referenced
this pull request
Nov 7, 2014
es 1.4.0 needs index.version.created in its settings, added parameter to...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... pass settings to typemapping.
v1.4.0 of ES requires index.version.created to be set in the settings. I therefore changed the method signature to require a settings param, since the BuilderContext in GenericTypeMapping used to pass empty settings to the check (before 1.3 it passed null) which always led to an exception on startup even if esi4j got initalised with the required setting.