New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative AMD moment dependency #3082
Conversation
Please close this PR if #1989 is still valid. |
Should this change also include removing the "main" property from package.json? (Honest question - I can never keep track of how all these module loaders work) |
@icambron well nobody does, that is part of the problem. I don't think we have to remove the main. @dasa, how is using |
@ichernev - this PR is to change the locales from using |
An alternative solution for avoiding requiring |
So, I'm not good at module loading stuff, but I want to clean house on pull requests, so I'm wondering, what specific problem does this fix? Like, 'when I am using system.js and I want to do x, I can't do that because y, and this fixes that'. |
This change is to remove the requirement to have to define a |
OK, I'm merging this, as requirejs' maintainers suggested. |
Merged in fb9a5c3 |
Use relative AMD moment dependency
Use a relative AMD dependency so that it's not required to have the
main
defined for themoment
package.