toDate returns a copy of the internal date object #3191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Is there any reason why we can't just call return new Date(this.valueOf());and do away with the ternary? Seems to me it would have the same result, and it would work correctly with Tim's pull request that we've been talking about bringing in. In either case, some kind of a unit test should be added for it. It seems like a trivial test case, but that way we ensure that nobody puts it back the other way for some strange reason. |
|
@maggiepint I agree on both points. |
|
@maggiepint @icambron addressed your suggestions, let me know what you think. Happy to take another pass at it. |
|
Looks great. Will merge in next release. |
|
Merged in 1df38b4 |
ichernev
added a commit
that referenced
this pull request
Jun 14, 2016
toDate returns a copy of the internal date object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moment#toDate currently returns the internal date object, which can lead to strange behaviour if the moment object is then modified. See this fiddle for an example.