fix: requestList concurrency (#241)

monkeyWie · Nov 17, 2022 · 37bc807 · 37bc807
1 parent b3fd35e
commit 37bc807
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -25,7 +25,7 @@ Proxyee is a JAVA written HTTP proxy server library that supports HTTP, HTTPS, W
 <dependency>
     <groupId>com.github.monkeywie</groupId>
     <artifactId>proxyee</artifactId>
-    <version>1.7.0</version>
+    <version>1.7.1</version>
 </dependency>
 ```
 

diff --git a/README_zh-CN.md b/README_zh-CN.md
@@ -25,7 +25,7 @@ Proxyee 是一个 JAVA 编写的 HTTP 代理服务器类库，支持 HTTP、HTTP
 <dependency>
     <groupId>com.github.monkeywie</groupId>
     <artifactId>proxyee</artifactId>
-    <version>1.7.0</version>
+    <version>1.7.1</version>
 </dependency>
 ```
 

diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
 
     <groupId>com.github.monkeywie</groupId>
     <artifactId>proxyee</artifactId>
-    <version>1.7.0</version>
+    <version>1.7.1</version>
 
     <packaging>jar</packaging>
 

diff --git a/src/main/java/com/github/monkeywie/proxyee/handler/HttpProxyServerHandler.java b/src/main/java/com/github/monkeywie/proxyee/handler/HttpProxyServerHandler.java
@@ -323,14 +323,16 @@ private void handleProxyData(Channel channel, Object msg, boolean isHttp) throws
             getChannelFuture().addListener((ChannelFutureListener) future -> {
                 if (future.isSuccess()) {
                     future.channel().writeAndFlush(msg);
-                    synchronized (requestList) {
+                    synchronized (getRequestList()) {
                         getRequestList().forEach(obj -> future.channel().writeAndFlush(obj));
                         getRequestList().clear();
                         setIsConnect(true);
                     }
                 } else {
-                    getRequestList().forEach(obj -> ReferenceCountUtil.release(obj));
-                    getRequestList().clear();
+                    synchronized (getRequestList()) {
+                        getRequestList().forEach(obj -> ReferenceCountUtil.release(obj));
+                        getRequestList().clear();
+                    }
                     getExceptionHandle().beforeCatch(channel, future.cause());
                     future.channel().close();
                     channel.close();