gestalt/get shouldn't throw an exception for false/nil values #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
gestalt/getreturned the value it foundorthrew anIllegalArgumentException; theormeans that if it found a falsey value, rather than returning that value, it threw. This is changed to have it return whatever it finds, and only throw when the requested keys doesn't exist in the configuration.gestalt/contains?already sort of had that behaviour, except that it only supported a single key, rather than a sequence of keys like you could pass togestalt/get. This is changed so that you can pass the same arguments togestalt/contains?as togestalt/get.Now, for keys
&ks, if(apply gestalt/contains? ks)istrue,(apply gestalt/get ks)will return a value, and if(apply gestalt/contains? ks)isfalse,(apply gestalt/get ks)will throw.