Skip to content

Commit

Permalink
MDL-66301 forumreport_summary: Made nodetitle string more specific
Browse files Browse the repository at this point in the history 
This is needed now course-level forum summary reports are available,
otherwise places like breadcrumbs are not clear that it relates
to forum data.
  • Loading branch information
@mickhawkins
mickhawkins committed Apr 2, 2020
1 parent 380ae3f commit 0e759f6
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion mod/forum/report/summary/lang/en/forumreport_summary.php
View file
Expand Up @@ -43,7 +43,7 @@
$string['latestpost'] = 'Most recent post';
$string['exportposts'] = 'Export posts';
$string['exportpostslabel'] = 'Export posts for {$a}';
$string['nodetitle'] = 'Summary report';
$string['nodetitle'] = 'Forum summary report';
$string['pluginname'] = 'Forum summary report';
$string['postcount'] = 'Number of discussions posted';
$string['privacy:metadata'] = 'The Forum summary report plugin does not store any personal data.';
Expand Down
6 changes: 3 additions & 3 deletions mod/forum/report/summary/tests/behat/bulk_message.feature
View file
Expand Up @@ -43,7 +43,7 @@ Feature: Message users in the summary report
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
And I click on "Select 'Student 1'" "checkbox"
And I click on "Select 'Student 3'" "checkbox"
And I set the field "With selected users..." to "Send a message"
Expand All @@ -65,7 +65,7 @@ Feature: Message users in the summary report
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
And I click on "Select all" "checkbox"
And I set the field "With selected users..." to "Send a message"
Then I should see "Send message to 3 people"
Expand All @@ -79,6 +79,6 @@ Feature: Message users in the summary report
And I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then I should not see "With selected users..."
And I should not see "Select all"
4 changes: 2 additions & 2 deletions mod/forum/report/summary/tests/behat/course_summary.feature
View file
Expand Up @@ -58,7 +58,7 @@ Feature: Course level forum summary report
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum2"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
And I should see "Export posts"
And the following should exist in the "forumreport_summary_table" table:
# | | Discussions | Replies | | |
Expand Down Expand Up @@ -93,7 +93,7 @@ Feature: Course level forum summary report
When I log in as "student1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
And the following should exist in the "forumreport_summary_table" table:
# | | Discussions | Replies | | |
| First name / Surname | -2- | -3- | Earliest post | Most recent post |
Expand Down
4 changes: 2 additions & 2 deletions mod/forum/report/summary/tests/behat/private_replies.feature
View file
Expand Up @@ -44,7 +44,7 @@ Feature: Include private replies in the summary report
When I log in as "teacher2"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Teacher 1" row "Number of replies posted" column of "forumreport_summary_table" table should contain "3"

Scenario: Private replies are not counted when Teacher has not capability
Expand All @@ -54,5 +54,5 @@ Feature: Include private replies in the summary report
When I log in as "teacher2"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Teacher 1" row "Number of replies posted" column of "forumreport_summary_table" table should contain "2"
6 changes: 3 additions & 3 deletions mod/forum/report/summary/tests/behat/summary_data_access.feature
View file
Expand Up @@ -36,7 +36,7 @@ Feature: Report relevant content availability
Given I log in as "teacher1"
When I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then the following should exist in the "forumreport_summary_table" table:
| -2- | -3- | -4- | -5- | -6- | -7- | -8- |
| Student 1 | 1 | 1 | 5 | 0 | 3 | 14 |
Expand All @@ -60,7 +60,7 @@ Feature: Report relevant content availability
Given I log in as "student1"
When I am on "Course 1" course homepage
And I follow "forum1"
Then "Summary report" "link" should not exist in current page administration
Then "Forum summary report" "link" should not exist in current page administration

@javascript
Scenario: Students given the view capability can only view their own report data
Expand All @@ -70,7 +70,7 @@ Feature: Report relevant content availability
When I log in as "student1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then the following should exist in the "forumreport_summary_table" table:
| -1- | -2- | -3- | -4- | -5- | -6- | -7- |
| Student 1 | 1 | 1 | 5 | 1 | 3 | 14 |
Expand Down
2 changes: 1 addition & 1 deletion mod/forum/report/summary/tests/behat/summary_data_attachments.feature
View file
Expand Up @@ -44,7 +44,7 @@ Feature: Attachments count column data available
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Teacher 1" row "Number of attachments" column of "forumreport_summary_table" table should contain "6"
And "Student 1" row "Number of attachments" column of "forumreport_summary_table" table should contain "5"
And "Student 2" row "Number of attachments" column of "forumreport_summary_table" table should contain "0"
2 changes: 1 addition & 1 deletion mod/forum/report/summary/tests/behat/summary_data_post_dates.feature
View file
Expand Up @@ -46,7 +46,7 @@ Feature: Post date columns data available
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Teacher 1" row "Earliest post" column of "forumreport_summary_table" table should contain "Tuesday, 2 January 2018, 9:00 AM"
Then "Teacher 1" row "Most recent post" column of "forumreport_summary_table" table should contain "Sunday, 1 September 2019, 7:00 AM"
Then "Student 1" row "Earliest post" column of "forumreport_summary_table" table should contain "Wednesday, 27 March 2019, 4:00 AM"
Expand Down
12 changes: 6 additions & 6 deletions mod/forum/report/summary/tests/behat/summary_filter_groups.feature
View file
Expand Up @@ -65,7 +65,7 @@ Feature: Groups report filter is available if groups exist
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Groups" "button" should exist
And the following should exist in the "forumreport_summary_table" table:
# | | Discussions | Replies |
Expand Down Expand Up @@ -115,7 +115,7 @@ Feature: Groups report filter is available if groups exist
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Groups" "button" should exist
And the following should exist in the "forumreport_summary_table" table:
# | | Discussions | Replies |
Expand Down Expand Up @@ -151,7 +151,7 @@ Feature: Groups report filter is available if groups exist
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum2"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Groups" "button" should exist
And the following should exist in the "forumreport_summary_table" table:
# | | Discussions | Replies |
Expand All @@ -177,7 +177,7 @@ Feature: Groups report filter is available if groups exist
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum2"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then the following should exist in the "forumreport_summary_table" table:
# | | Discussions | Replies |
| First name / Surname | -3- | -4- |
Expand All @@ -202,7 +202,7 @@ Feature: Groups report filter is available if groups exist
When I log in as "admin"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Groups" "button" should exist
And the following should exist in the "forumreport_summary_table" table:
# | | Discussions | Replies |
Expand All @@ -227,7 +227,7 @@ Feature: Groups report filter is available if groups exist
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum2"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
And I select "All forums in course" from the "Forum selected" singleselect
And I click on "Groups" "button"
And I click on "Clear" "button" in the "filter-groups-popover" "region"
Expand Down
2 changes: 1 addition & 1 deletion mod/forum/report/summary/tests/behat/summary_filter_no_groups.feature
View file
Expand Up @@ -52,7 +52,7 @@ Feature: Groups report filter is not available if no groups exist
When I log in as "teacher1"
And I am on "Course 1" course homepage
And I follow "forum1"
And I navigate to "Summary report" in current page administration
And I navigate to "Forum summary report" in current page administration
Then "Groups" "button" should not exist
And the following should exist in the "forumreport_summary_table" table:
# | | Discussions |
Expand Down

0 comments on commit 0e759f6

Please sign in to comment.