Skip to content

Commit

Permalink
MDL-73452 navigation: Update to Course reuse string in secondary nav
Browse files Browse the repository at this point in the history
Previously this used the "Course administration" string, which causes
some confusion for those familiar with the older usage of that string.
A new "Course reuse" string has been added to better reflect what is
being linked to in course secondary navigation.
  • Loading branch information
mickhawkins committed Feb 1, 2022
1 parent 4f9a539 commit 537e31c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions lang/en/moodle.php
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@
$string['courserequestsupport'] = 'Supporting information to help the administrator evaluate this request';
$string['courserequestwarning'] = 'The user requesting this course will be automatically enrolled and assigned the role of {$a}.';
$string['courserestore'] = 'Course restore';
$string['coursereuse'] = 'Course reuse';
$string['courses'] = 'Courses';
$string['coursesectionsummaries'] = 'Course section summaries';
$string['coursesectiontitle'] = 'Course: {$a->course}, {$a->sectionname}: {$a->sectiontitle}';
Expand Down
4 changes: 2 additions & 2 deletions lib/classes/navigation/views/secondary.php
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ protected function load_course_navigation(): void {
return;
}
$actionnode = $this->get_first_action_for_node($overflownode);
// All additional nodes will be available under the 'Course admin' page.
$text = get_string('courseadministration');
// All additional nodes will be available under the 'Course reuse' page.
$text = get_string('coursereuse');
$this->add($text, $actionnode->action, null, null, 'courseadmin', new \pix_icon('t/edit', $text));
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@javascript @theme_boost
Feature: Course administration navigation
Feature: Course reuse navigation
As a teacher
I can navigate to course administration pages
I can navigate to course reuse pages

Background:
Given the following "courses" exist:
Expand All @@ -17,13 +17,13 @@ Feature: Course administration navigation
Scenario: A Teacher can navigate to the course Import page.
Given I log in as "teacher1"
When I am on "Course 1" course homepage
And I navigate to "Course administration" in current page administration
And I navigate to "Course reuse" in current page administration
Then I should see "Find a course to import data from:"

Scenario Outline: A Teacher can navigate to other course administration pages.
Scenario Outline: A Teacher can navigate to other Course reuse pages.
Given I log in as "teacher1"
When I am on "Course 1" course homepage
And I navigate to "Course administration" in current page administration
And I navigate to "Course reuse" in current page administration
And I select "<adminpage>" from the "jump" singleselect
Then I should see "<title>"

Expand All @@ -37,6 +37,6 @@ Feature: Course administration navigation
Scenario: An Administrator can view the course copy page.
Given I log in as "admin"
When I am on "Course 1" course homepage
And I navigate to "Course administration" in current page administration
And I navigate to "Course reuse" in current page administration
And I select "Copy course" from the "jump" singleselect
Then I should see "This course will be duplicated and put into the selected course category"

0 comments on commit 537e31c

Please sign in to comment.