MDL-76867 core_admin: Standardise plugin management when plugin missi…

…ng from disk
moodle · Mar 14, 2023 · 573066b · 573066b
1 parent 6aba049
commit 573066b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/admin/classes/table/activity_management_table.php b/admin/classes/table/activity_management_table.php
@@ -70,7 +70,7 @@ protected function col_name(stdClass $row): string {
         $status = $row->plugininfo->get_status();
         if ($status === core_plugin_manager::PLUGIN_STATUS_MISSING) {
             return html_writer::span(
-                get_string('missingfromdisk'),
+                get_string('pluginmissingfromdisk', 'core', $row->plugininfo),
                 'notifyproblem'
             );
         }

diff --git a/admin/classes/table/plugin_management_table.php b/admin/classes/table/plugin_management_table.php
@@ -275,6 +275,14 @@ public function is_downloadable($downloadable = null): bool {
      * @return string
      */
     protected function col_name(stdClass $row): string {
+        $status = $row->plugininfo->get_status();
+        if ($status === core_plugin_manager::PLUGIN_STATUS_MISSING) {
+            return html_writer::span(
+                get_string('pluginmissingfromdisk', 'core', $row->plugininfo),
+                'notifyproblem'
+            );
+        }
+
         if ($row->plugininfo->is_installed_and_upgraded()) {
             return $row->plugininfo->displayname;
         }

diff --git a/lang/en/moodle.php b/lang/en/moodle.php
@@ -1663,6 +1663,7 @@
 $string['plugindeletefiles'] = 'All data associated with the plugin \'{$a->name}\' has been deleted from the database. To prevent the plugin re-installing itself, you should now delete this directory from your server: {$a->directory}';
 $string['plugincheck'] = 'Plugins check';
 $string['pluginitemid'] = 'Item ID';
+$string['pluginmissingfromdisk'] = '{$a->name} (Missing from disk)';
 $string['pluginsetup'] = 'Setting up plugin tables';
 $string['policyaccept'] = 'I understand and agree';
 $string['policyagree'] = 'You must agree to this policy to continue using this site.  Do you agree?';