Skip to content

Commit

Permalink
MDL-75155 behat: Add select_menu field type
Browse files Browse the repository at this point in the history
This commit introduces a new partial selector for select_menu fields,
and teaching the field manager how to recognise these, then introducing
a new field type which can handle setting values for this field.
  • Loading branch information
rezaies committed Sep 6, 2022
1 parent 2702885 commit 5d33ef3
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lib/behat/behat_field_manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ public static function guess_field_type(NodeElement $fieldnode, Session $session
}
}

if ($tagname == 'div') {
if ($node->getAttribute('role') == 'combobox') {
return 'select_menu';
}
}

// We can not provide a closer field type.
return false;
}
Expand Down
5 changes: 5 additions & 0 deletions lib/behat/classes/partial_named_selector.php
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ public function __construct() {
'date_time' => <<<XPATH
.//fieldset[(%idMatch% or ./legend[%exactTagTextMatch%]) and (@data-fieldtype='date' or @data-fieldtype='date_time')]
XPATH
,
'select_menu' => <<<XPATH
//*[@role='combobox'][@aria-labelledby = //label[contains(normalize-space(string(.)), %locator%)]/@id]
XPATH
,
],
];

Expand Down
48 changes: 48 additions & 0 deletions lib/behat/form_field/behat_form_select_menu.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

declare(strict_types=1);

require_once(__DIR__ . '/behat_form_field.php');

/**
* Custom interaction with select_menu elements
*
* @package core_form
* @copyright 2022 Shamim Rezaie <shamim@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class behat_form_select_menu extends behat_form_field {
public function set_value($value) {
self::require_javascript();

$rootnode = $this->field->getParent();
$options = $rootnode->findAll('css', '[role=option]');
$this->field->click();
foreach ($options as $option) {
if (trim($option->getHtml()) == $value) {
$option->click();
break;
}
}
}

public function get_value() {
$rootnode = $this->field->getParent();
$input = $rootnode->find('css', 'input');
return $input->getValue();
}
}

0 comments on commit 5d33ef3

Please sign in to comment.