Skip to content

Commit

Permalink
MDL-79108 completion: Display the correct message in default settings
Browse files Browse the repository at this point in the history
  • Loading branch information
sarjona committed Aug 28, 2023
1 parent 9bfcd77 commit 610a70f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
Expand Up @@ -95,6 +95,7 @@ public function defaultcompletion($data, $modules, $form) {
$module->formhtml = $modform->render();
}
}
$data->issite = $course->id == SITEID;

return parent::render_from_template('core_course/defaultactivitycompletion', $data);
}
Expand Down
9 changes: 7 additions & 2 deletions course/templates/defaultactivitycompletion.mustache
Expand Up @@ -32,12 +32,17 @@
"string": "Manual",
"icon": "https://raw.githubusercontent.com/moodle/moodle/master/pix/i/completion-manual-enabled.png"
}
}]
}],
"issite": true
}
}}
<div class="container-fluid">
<div class="row my-5 defaultactivitycompletion-header">
<div class="col">{{#str}}defaultactivitycompletion, core_completion{{/str}}</div>
<div class="col">
{{#issite}}{{#str}}defaultactivitycompletionsite, core_completion{{/str}}{{/issite}}
{{^issite}}{{#str}}defaultactivitycompletioncourse, core_completion{{/str}}{{/issite}}
</div>

</div>

<div class="modules pt-3">
Expand Down
3 changes: 2 additions & 1 deletion lang/en/completion.php
Expand Up @@ -145,7 +145,8 @@
$string['days'] = 'Days';
$string['daysoftotal'] = '{$a->days} of {$a->total}';
$string['daysuntilcompletion'] = 'Days until completion';
$string['defaultactivitycompletion'] = 'These are the default completion conditions for activities in all courses.';
$string['defaultactivitycompletionsite'] = 'These are the default completion conditions for activities in all courses.';
$string['defaultactivitycompletioncourse'] = 'These are the default completion conditions for activities in this course.';
$string['defaultcompletion'] = 'Default activity completion';
$string['defaultcompletionupdated'] = 'Changes saved';
$string['deletecompletiondata'] = 'Delete completion data';
Expand Down

0 comments on commit 610a70f

Please sign in to comment.