Skip to content

Commit

Permalink
MDL-57602 mod_assign: Add 'Granted extension' filter for grading table
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyjbutler committed Feb 16, 2017
1 parent 9ec952f commit 696bd4d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
3 changes: 2 additions & 1 deletion mod/assign/gradingoptionsform.php
Expand Up @@ -60,7 +60,8 @@ public function definition() {
$options = array('' => get_string('filternone', 'assign'),
ASSIGN_FILTER_NOT_SUBMITTED => get_string('filternotsubmitted', 'assign'),
ASSIGN_FILTER_SUBMITTED => get_string('filtersubmitted', 'assign'),
ASSIGN_FILTER_REQUIRE_GRADING => get_string('filterrequiregrading', 'assign'));
ASSIGN_FILTER_REQUIRE_GRADING => get_string('filterrequiregrading', 'assign'),
ASSIGN_FILTER_GRANTED_EXTENSION => get_string('filtergrantedextension', 'assign'));
if ($instance['submissionsenabled']) {
$mform->addElement('select', 'filter', get_string('filter', 'assign'), $options, $dirtyclass);
}
Expand Down
3 changes: 3 additions & 0 deletions mod/assign/gradingtable.php
Expand Up @@ -287,6 +287,9 @@ public function __construct(assign $assignment,
$where .= '))';
$params['submitted'] = ASSIGN_SUBMISSION_STATUS_SUBMITTED;

} else if ($filter == ASSIGN_FILTER_GRANTED_EXTENSION) {
$where .= ' AND uf.extensionduedate > 0 ';

} else if (strpos($filter, ASSIGN_FILTER_SINGLE_USER) === 0) {
$userfilter = (int) array_pop(explode('=', $filter));
$where .= ' AND (u.id = :userid)';
Expand Down
1 change: 1 addition & 0 deletions mod/assign/lang/en/assign.php
Expand Up @@ -232,6 +232,7 @@
$string['feedbacktypes'] = 'Feedback types';
$string['filesubmissions'] = 'File submissions';
$string['filter'] = 'Filter';
$string['filtergrantedextension'] = 'Granted extension';
$string['filternone'] = 'No filter';
$string['filternotsubmitted'] = 'Not submitted';
$string['filterrequiregrading'] = 'Requires grading';
Expand Down
1 change: 1 addition & 0 deletions mod/assign/locallib.php
Expand Up @@ -37,6 +37,7 @@
define('ASSIGN_FILTER_NOT_SUBMITTED', 'notsubmitted');
define('ASSIGN_FILTER_SINGLE_USER', 'singleuser');
define('ASSIGN_FILTER_REQUIRE_GRADING', 'require_grading');
define('ASSIGN_FILTER_GRANTED_EXTENSION', 'granted_extension');

// Marker filter for grading page.
define('ASSIGN_MARKER_FILTER_NO_MARKER', -1);
Expand Down

0 comments on commit 696bd4d

Please sign in to comment.