Skip to content

Commit

Permalink
MDL-53988 mod_lti: Fix followup up issues
Browse files Browse the repository at this point in the history
Fix function naming
Fix param types
Fix error popping up twice with incorrect URL
Add confirm dialog when you delete a tool
Show orphaned tool proxies in list
Fix interface jumping up and down
Change to use notification stack
Change capabilities in db/services.php
Add loading animation after registering tool
Show loading animation until tools are rendered
  • Loading branch information
John Okely committed May 19, 2016
1 parent 33892ed commit 811d9ff
Show file tree
Hide file tree
Showing 30 changed files with 841 additions and 213 deletions.
2 changes: 1 addition & 1 deletion lib/amd/build/notification.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions lib/amd/src/notification.js
Expand Up @@ -137,7 +137,7 @@ function(Y, $, log) {
});
},

confirm: function(title, question, yesLabel, noLabel, callback) {
confirm: function(title, question, yesLabel, noLabel, yesCallback, noCallback) {
// Here we are wrapping YUI. This allows us to start transitioning, but
// wait for a good alternative without having inconsistent dialogues.
Y.use('moodle-core-notification-confirm', function () {
Expand All @@ -149,8 +149,13 @@ function(Y, $, log) {
});

modal.on('complete-yes', function() {
callback();
yesCallback();
});
if (noCallback) {
modal.on('complete-no', function() {
noCallback();
});
}
modal.show();
});
},
Expand Down Expand Up @@ -225,7 +230,8 @@ function(Y, $, log) {
* @param {string} question
* @param {string} yesLabel
* @param {string} noLabel
* @param {function} callback
* @param {function} yesCallback
* @param {function} noCallback Optional parameter to be called if the user presses cancel.
*/
confirm: notificationModule.confirm,

Expand Down
2 changes: 1 addition & 1 deletion mod/lti/amd/build/external_registration.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 811d9ff

Please sign in to comment.