MDL-26567 no grade category option on the quiz settings form.

Also, refine the standard_grading_coursemodule_elements method to add a help string. AMOS BEGIN CPY [gradecategory,grades],[gradecategoryonmodform,grades] AMOS END
moodle · Sep 20, 2011 · b9bed21 · b9bed21
1 parent 3df2ab8
commit b9bed21
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/course/moodleform_mod.php b/course/moodleform_mod.php
@@ -654,8 +654,10 @@ public function standard_grading_coursemodule_elements() {
             }
 
             if ($this->_features->gradecat) {
-                $categories = grade_get_categories_menu($COURSE->id, $this->_outcomesused);
-                $mform->addElement('select', 'gradecat', get_string('gradecategory', 'grades'), $categories);
+                $mform->addElement('select', 'gradecat',
+                        get_string('gradecategoryonmodform', 'grades'),
+                        grade_get_categories_menu($COURSE->id, $this->_outcomesused));
+                $mform->addHelpButton('gradecat', 'gradecategoryonmodform', 'grades');
             }
         }
     }

diff --git a/lang/en/grades.php b/lang/en/grades.php
@@ -219,7 +219,8 @@
 $string['gradeboundary_help'] = 'This setting determines the minimum percentage over which grades will be assigned the grade letter.';
 $string['gradecategories'] = 'Grade categories';
 $string['gradecategory'] = 'Grade category';
-$string['gradecategoryhelp'] = 'Grade category help';
+$string['gradecategoryonmodform'] = 'Grade category';
+$string['gradecategoryonmodform_help'] =  'This setting controls the category in which this activity\'s grades are placed in the gradebook.';
 $string['gradecategorysettings'] = 'Grade category settings';
 $string['gradedisplay'] = 'Grade display';
 $string['gradedisplaytype'] = 'Grade display type';

diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php
@@ -1622,7 +1622,7 @@ function quiz_supports($feature) {
         case FEATURE_MOD_INTRO:               return true;
         case FEATURE_COMPLETION_TRACKS_VIEWS: return true;
         case FEATURE_GRADE_HAS_GRADE:         return true;
-        case FEATURE_GRADE_OUTCOMES:          return true;
+        case FEATURE_GRADE_OUTCOMES:          return false;
         case FEATURE_BACKUP_MOODLE2:          return true;
 
         default: return null;

diff --git a/mod/quiz/mod_form.php b/mod/quiz/mod_form.php
@@ -86,6 +86,14 @@ function definition() {
         $mform->setDefault('grademethod', $quizconfig->grademethod);
         $mform->disabledIf('grademethod', 'attempts', 'eq', 1);
 
+//-------------------------------------------------------------------------------
+        // Grade settings
+        $this->standard_grading_coursemodule_elements();
+
+        $mform->removeElement('grade');
+        $mform->addElement('hidden', 'grade', $quizconfig->maximumgrade);
+        $mform->setType('grade', PARAM_NUMBER);
+
 //-------------------------------------------------------------------------------
         $mform->addElement('header', 'layouthdr', get_string('layout', 'quiz'));
 
@@ -281,8 +289,6 @@ function definition() {
         $mform->addElement('header', 'overallfeedbackhdr', get_string('overallfeedback', 'quiz'));
         $mform->addHelpButton('overallfeedbackhdr', 'overallfeedback', 'quiz');
 
-        $mform->addElement('hidden', 'grade', $quizconfig->maximumgrade);
-        $mform->setType('grade', PARAM_RAW);
         if (empty($this->_cm)) {
             $needwarning = $quizconfig->maximumgrade == 0;
         } else {