MDL-21695 Got rid of the last call of setHelpButton()

moodle · Aug 16, 2010 · cde9bee · cde9bee
1 parent ed14ad0
commit cde9bee
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 19 deletions.
diff --git a/lang/en/help/portfolio/boxnet_apikey.html b/lang/en/help/portfolio/boxnet_apikey.html
diff --git a/lib/formslib.php b/lib/formslib.php
@@ -1437,7 +1437,8 @@ function setHelpButtons($buttons, $suppresscheck=false, $function='helpbutton'){
      */
     function setHelpButton($elementname, $buttonargs, $suppresscheck=false, $function='helpbutton'){
         global $OUTPUT;
-        //TODO: obsolete this function completely
+
+        debugging('function moodle_form::setHelpButton() is deprecated');
         if ($function !== 'helpbutton') {
             //debugging('parameter $function in moodle_form::setHelpButton() is not supported any more');
         }

diff --git a/portfolio/boxnet/lang/en/portfolio_boxnet.php b/portfolio/boxnet/lang/en/portfolio_boxnet.php
@@ -24,7 +24,6 @@
  */
 
 $string['apikey'] = 'API key';
-$string['apikeyhelp'] = 'You need to get this by signing up to box.net as a developer and adding an application.  The callback url must be yourwwwroot/portfolio/add.php?postcontrol=1&type=boxnet';
 $string['apikeyinlinehelp'] = '<p>To configure Box.net, visit the developer page at <a href="http://www.box.net/developers/services">box.net</a> and log in.</p><p>Under My Projects you will need to create one new project for each Moodle site.</p><p>The only setting that matters is the callback url, which should be {$a}. You can put anything you like for the other settings. Save it and you\'re done!';
 $string['err_noapikey'] = 'No API Key';
 $string['err_noapikey_help'] = 'There is no API Key configured for this plugin.  You can get one of these from http://enabled.box.net';

diff --git a/portfolio/boxnet/lib.php b/portfolio/boxnet/lib.php
@@ -110,12 +110,6 @@ public function admin_config_form(&$mform) {
         global $CFG;
         $strrequired = get_string('required');
         $mform->addElement('text', 'apikey', get_string('apikey', 'portfolio_boxnet'));
-        $helpparams = array(
-            'boxnet_apikey',
-            get_string('apikeyhelp', 'portfolio_boxnet'),
-            'portfolio',
-        );
-        $mform->setHelpButton('apikey', $helpparams);
         $mform->addRule('apikey', $strrequired, 'required', null, 'client');
         $mform->addElement('warning', 'apikeyhelp', 'smalltext', get_string('apikeyinlinehelp', 'portfolio_boxnet', $CFG->wwwroot . '/portfolio/add.php?postcontrol=1&type=boxnet'));