MDL-72928 login: Update styling and functionality

admin/tool/componentlibrary/content/moodle/components/dom-modal.md

@@ -0,0 +1,134 @@
+
+---
+layout: docs
+title: "HTML Modals"
+description: "A reusable handled modal component"
+date: 2021-12-09T14:48:00+08:00
+draft: false
+tags:
+- MDL-71963
+- MDL-72928
+- "4.0"
+---
+
+## How it works
+
+The core/utility module allows different modals to be displayed automatically when interacting with the page.
+
+Modals are configured using a set of specific data-attributes.
+
+## Source files
+
+* `lib/amd/src/utility.js` ({{< jsdoc module="core/utility" >}})
+* `lib/templates/modal.mustache`
+
+## Usage
+The confirmation AMD module is loaded automatically, so the only thing you need to do is to add some specific data attributes
+to the target element.
+
+To display a confirmation modal.
+{{< highlight html >}}
+<button type="button" class="btn btn-primary" data-modal="confirmation" data-modal-title-str='["delete", "core"]'
+data-modal-content-str='["areyousure"]' data-modal-yes-button-str='["delete", "core"]'>Show confirmation modal</button>
+{{< /highlight >}}
+
+To display an alert modal.
+{{< highlight html >}}
+<button type="button" class="btn btn-primary" data-modal="alert" data-modal-title-str='["cookiesenabled", "core"]'
+data-modal-content-str='["cookiesenabled_help_html", "core"]'>Show alert modal</button>
+{{< /highlight >}}
+
+You can also use it on PHP, you just need to set the attributes parameter to any moodle output component that takes attributes:
+{{< php >}}
+echo $OUTPUT->single_button('#', get_string('delete'), 'get', [
+    'data-modal' => 'modal',
+    'data-modal-title-str' => json_encode(['delete', 'core']),
+    'data-modal-content-str' => json_encode(['areyousure']),
+    'data-modal-yes-button-str' => json_encode(['delete', 'core'])
+]);
+{{< / php >}}
+
+## Attributes
+
+<table class="table">
+  <thead>
+    <tr>
+      <th style="width: 250px;">Data attribute</th>
+      <th>Description</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr>
+      <td>data-modal</td>
+      <td>One of either "confirmation", or "alert".</td>
+    </tr>
+    <tr>
+      <td>data-modal-title-str</td>
+      <td>The modal title language string identifier, must be provided in JSON encoded format.</td>
+    </tr>
+    <tr>
+      <td>data-modal-content-str</td>
+      <td>The modal content or content language string identifier, must be provided in JSON encoded format.</td>
+    </tr>
+    <tr>
+      <td>data-modal-yes-button-str</td>
+      <td>
+        The language string identifier for the "Yes" button, must be provided in JSON encoded format.
+        Confirmation modals only.
+      </td>
+    </tr>
+    <tr>
+      <td>data-modal-toast</td>
+      <td>
+        If set to "true" it will display a modal toast in the end.
+        Confirmation modals only.
+      </td>
+    </tr>
+    <tr>
+      <td>data-modal-toast-confirmation-str</td>
+      <td>
+        The confirmation toast language string identifier, must be provided in JSON encoded format.
+        Confirmation modals only.
+      </td>
+    </tr>
+    <tr>
+      <td>data-modal-destination</td>
+      <td>
+        An url to redirect the user to.
+        Confirmation modals only.
+      </td>
+    </tr>
+  </tbody>
+</table>
+
+## Examples
+
+### Basic Alert modal
+
+{{< example >}}
+<button type="button" class="btn btn-primary" data-modal="alert" data-modal-title-str='["cookiesenabled", "core"]'
+data-modal-content-str='["cookiesenabled_help_html", "core"]'>Show alert modal</button>
+{{< /example >}}
+
+### Basic confirmation modal
+
+{{< example >}}
+<button type="button" class="btn btn-primary" data-modal="confirmation" data-modal-title-str='["delete", "core"]'
+data-modal-content-str='["areyousure"]' data-modal-yes-button-str='["delete", "core"]'>Show confirmation modal</button>
+{{< /example >}}
+
+### Confirmation modal with a toast
+
+{{< example >}}
+<button type="button" class="btn btn-primary" data-modal="confirmation" data-modal-title-str='["delete", "core"]'
+data-modal-content-str='["areyousure"]' data-modal-yes-button-str='["delete", "core"]' data-modal-toast="true"
+data-modal-toast-confirmation-str='["deleteblockinprogress", "block", "Online users"]'>Show confirmation modal</button>
+{{< /example >}}
+
+### Confirmation modal with redirect
+
+{{< example >}}
+<button type="button" class="btn btn-primary" data-modal="confirmation" data-modal-title-str='["delete", "core"]'
+data-modal-content-str='["areyousure"]' data-modal-yes-button-str='["delete", "core"]'
+data-modal-destination="http://moodle.com">Show confirmation modal</button>
+{{< /example >}}

auth/tests/behat/rememberusername.feature

@@ -24,27 +24,3 @@ Feature: Test the 'remember username' feature works.
     And I click on "Log in" "link" in the ".logininfo" "css_element"
     Then the field "username" matches value "teacher1"
     And the field "Remember username" matches value "1"
-
-  # Given the user has logged in before and selected 'Remember username', when they log in again and unset 'Remember username', then
-  # their username should be forgotten for future log in attempts.
-  Scenario: Check that 'remember username' unsetting works without javascript for teachers.
-    # Log in the first time and check the 'remember username' box.
-    Given I am on homepage
-    And I click on "Log in" "link" in the ".logininfo" "css_element"
-    And I set the field "Username" to "teacher1"
-    And I set the field "Password" to "teacher1"
-    And I set the field "Remember username" to "1"
-    And I press "Log in"
-    And I log out
-    # Log in again, unsetting the 'remember username' field.
-    When I am on homepage
-    And I click on "Log in" "link" in the ".logininfo" "css_element"
-    And I set the field "Password" to "teacher1"
-    And I set the field "Remember username" to "0"
-    And I press "Log in"
-    And I log out
-    # Check username has been forgotten.
-    Then I am on homepage
-    And I click on "Log in" "link" in the ".logininfo" "css_element"
-    Then the field "username" matches value ""
-    And the field "Remember username" matches value "0"

lang/en/moodle.php

@@ -299,10 +299,16 @@
 
 The essential one is the session cookie, usually called MoodleSession. You must allow this cookie in your browser to provide continuity and to remain logged in when browsing the site. When you log out or close the browser, this cookie is destroyed (in your browser and on the server).
 
+The other cookie is purely for convenience, usually called MOODLEID or similar. It just remembers your username in the browser. This means that when you return to this site, the username field on the login page is already filled in for you. It is safe to refuse this cookie - you will just have to retype your username each time you log in.';
+$string['cookiesenabled_help_html'] = 'Two cookies are used on this site:<br/><br/>
+
+The essential one is the session cookie, usually called MoodleSession. You must allow this cookie in your browser to provide continuity and to remain logged in when browsing the site. When you log out or close the browser, this cookie is destroyed (in your browser and on the server).<br/><br/>
+
 The other cookie is purely for convenience, usually called MOODLEID or similar. It just remembers your username in the browser. This means that when you return to this site, the username field on the login page is already filled in for you. It is safe to refuse this cookie - you will just have to retype your username each time you log in.';
 $string['cookiesenabledonlysession'] = 'Cookies must be enabled in your browser';
 $string['cookiesenabledonlysession_help'] = 'This site uses one session cookie, usually called MoodleSession. You must allow this cookie in your browser to provide continuity and to remain logged in when browsing the site. When you log out or close the browser, this cookie is destroyed (in your browser and on the server).';
 $string['cookiesnotenabled'] = 'Unfortunately, cookies are currently not enabled in your browser';
+$string['cookiesnotice'] = 'Cookies notice';
 $string['copy'] = 'copy';
 $string['copyasnoun'] = 'copy';
 $string['copycourse'] = 'Copy course';
@@ -2250,7 +2256,7 @@
 $string['usermenu'] = 'User menu';
 $string['usermenugoback'] = 'Go back to user menu';
 $string['username'] = 'Username';
-$string['usernameemail'] = 'Username / email';
+$string['usernameemail'] = 'Username or email';
 $string['usernameemailmatch'] = 'The username and email address do not relate to the same user';
 $string['usernameexists'] = 'This username already exists, choose another';
 $string['usernamelowercase'] = 'Only lowercase letters allowed';