Skip to content

Commit

Permalink
MDL-49484 mod_lesson: Fix lesson page headers when editing
Browse files Browse the repository at this point in the history
  • Loading branch information
Josh Ebarvia committed Jun 23, 2017
1 parent 62c58d2 commit f3008f5
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 2 deletions.
18 changes: 18 additions & 0 deletions mod/lesson/lang/en/lesson.php
Expand Up @@ -42,16 +42,23 @@
$string['addaquestionpagehere'] = 'Add a question page here';
$string['addbranchtable'] = 'Add a content page';
$string['addcluster'] = 'Add a cluster';
$string['addessay'] = 'Create an Essay question page';
$string['addedabranchtable'] = 'Added a content page';
$string['addedanendofbranch'] = 'Added an end of branch';
$string['addedaquestionpage'] = 'Added a question page';
$string['addedcluster'] = 'Added a cluster';
$string['addedendofcluster'] = 'Added an end of cluster';
$string['addendofbranch'] = 'Add end of branch';
$string['addendofcluster'] = 'Add an end of cluster';
$string['addmatching'] = 'Create a Matching question page';
$string['addmultichoice'] = 'Create a Multichoice question page';
$string['addnewgroupoverride'] = 'Add group override';
$string['addnewuseroverride'] = 'Add user override';
$string['addnumerical'] = 'Create a Numerical question page';
$string['additionalattemptsremaining'] = 'Completed, You can re-attempt this lesson';
$string['addpage'] = 'Add a page';
$string['addshortanswer'] = 'Create a Short answer question page';
$string['addtruefalse'] = 'Create a True/false question page';
$string['and'] = 'AND';
$string['anchortitle'] = 'Start of main content';
$string['answer'] = 'Answer';
Expand Down Expand Up @@ -157,11 +164,22 @@
$string['displayscorewithoutessays'] = 'Your score is {$a->score} (out of {$a->grade}).';
$string['duplicatepagenamed'] = 'Duplicate page: {$a}';
$string['edit'] = 'Edit';
$string['editbranchtable'] = 'Editing a content page';
$string['editcluster'] = 'Editing a cluster';
$string['editendofcluster'] = 'Editing an end of cluster page';
$string['editendofbranch'] = 'Editing an end of branch page';
$string['editessay'] = 'Editing an Essay question page';
$string['editingquestionpage'] = 'Editing {$a} question page';
$string['editlessonsettings'] = 'Edit lesson settings';
$string['editmatching'] = 'Editing a Matching question page';
$string['editmultichoice'] = 'Editing a Multichoice question page';
$string['editnumerical'] = 'Editing a Numerical question page';
$string['editoverride'] = 'Edit override';
$string['editpage'] = 'Edit page contents';
$string['editpagecontent'] = 'Edit page contents';
$string['editquestion'] = 'Editing a question page';
$string['editshortanswer'] = 'Editing a Short answer question page';
$string['edittruefalse'] = 'Editing a True/false question page';
$string['email'] = 'Email';
$string['emailallgradedessays'] = 'Email ALL graded essays';
$string['emailgradedessays'] = 'Email graded essays';
Expand Down
8 changes: 7 additions & 1 deletion mod/lesson/locallib.php
Expand Up @@ -764,7 +764,13 @@ public final function definition() {
$mform = $this->_form;
$editoroptions = $this->_customdata['editoroptions'];

$mform->addElement('header', 'qtypeheading', get_string('createaquestionpage', 'lesson', get_string($this->qtypestring, 'lesson')));
if ($this->qtypestring != 'selectaqtype') {
if ($this->_customdata['edit']) {
$mform->addElement('header', 'qtypeheading', get_string('edit'. $this->qtypestring, 'lesson'));
} else {
$mform->addElement('header', 'qtypeheading', get_string('add'. $this->qtypestring, 'lesson'));
}
}

if (!empty($this->_customdata['returnto'])) {
$mform->addElement('hidden', 'returnto', $this->_customdata['returnto']);
Expand Down
6 changes: 5 additions & 1 deletion mod/lesson/pagetypes/branchtable.php
Expand Up @@ -319,7 +319,11 @@ public function custom_definition() {

$jumptooptions = lesson_page_type_branchtable::get_jumptooptions($firstpage, $lesson);

$mform->setDefault('qtypeheading', get_string('addabranchtable', 'lesson'));
if ($this->_customdata['edit']) {
$mform->setDefault('qtypeheading', get_string('editbranchtable', 'lesson'));
} else {
$mform->setDefault('qtypeheading', get_string('addabranchtable', 'lesson'));
}

$mform->addElement('hidden', 'firstpage');
$mform->setType('firstpage', PARAM_BOOL);
Expand Down

0 comments on commit f3008f5

Please sign in to comment.