Develop 348 date parse 1st regression #84
Conversation
https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/tickets/348-dateparse1st-regression - updates conditional in parse - adds spec for parsing 1st
|
well, this is what it used to be. So now Date.parse('Oct 31') fails. http://github.com/arian/mootools-more/commit/8c265cc56ff0c633606220846e5e36e03efd32d8 |
|
i just ran spec and it passed ? |
|
ok -- talked to arian, going to add the Date.parse('Oct 31') spec and see if i can get that working too... |
|
lgtm |
- updates code to pass all spec
|
It seems to work... So I squashed in one commit: http://github.com/arian/mootools-more/commit/6d4ea57d699b5fa9be0350bf23251c5b9b548e10 |
|
closing this... |
|
Reopening until pulled :) |
|
I wanted to pull this, but when running the new specs from this pull request WITHOUT changing Date.js itself it works with the latest master branch.... |
|
ooh, it's not... should check the specs better... the problem in the ticket was that it sets the month to January. The specs in the commit i posted above sets the month after parsing... so i'm updating the specs now :) |
|
This one it is: arian@9b1c234d4 |
|
Pushed my latest commit. |
fixes regression bug and adds spec
https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/tickets/348-dateparse1st-regression