Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-1886536: remove setup.cfg & setup.py in favor of pyproject.toml #986

Merged
merged 1 commit into from Mar 20, 2024
Merged

bug-1886536: remove setup.cfg & setup.py in favor of pyproject.toml #986

merged 1 commit into from Mar 20, 2024

Conversation

relud
Copy link
Member

@relud relud commented Mar 20, 2024

No description provided.

@relud relud requested a review from willkg March 20, 2024 19:19
@relud relud requested a review from a team as a code owner March 20, 2024 19:19
willkg
willkg approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is fine. I think we'll know for sure after the stage deploy.

@relud relud merged commit f34ee08 into main Mar 20, 2024
1 check passed
@relud relud deleted the s-setup-pyproject branch March 20, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkg willkg willkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@relud @willkg