Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1888223: remove priority from protected data access request link #6562

Merged
merged 1 commit into from Mar 28, 2024

Conversation

willkg
Copy link
Collaborator

@willkg willkg commented Mar 27, 2024

To test, do this:

  1. build socorro and then make run
  2. go to http://localhost:8000/documentation/protected_data_access/
  3. click on link to request protected data access
  4. make sure the priority isn't set to P3--it should be --

@willkg willkg requested a review from a team as a code owner March 27, 2024 19:56
@smarnach
Copy link
Contributor

I tried following the testing instructions, but I was held up by this typo in the Makefile: #6564

Copy link
Contributor

@biancadanforth biancadanforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ once the typo from #6564 was fixed it worked for me.

Copy link
Contributor

@smarnach smarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the test instructions, and on the "New bug" page in Bugzilla I get to when clicking the link there isn't any priority field. So I can't really verify that it's set to "--" since it's just not there. But the priority is definitly gone from the query parameters, so I guess it's fine.

@willkg
Copy link
Collaborator Author

willkg commented Mar 28, 2024

When I create the bug, it looks like this:

image

I bet you have advanced fields hidden. That'll make it look like this:

image

@willkg willkg merged commit 200edf0 into main Mar 28, 2024
1 check passed
@willkg
Copy link
Collaborator Author

willkg commented Mar 28, 2024

Thank you both for reviewing and fixing that make run issue!

@willkg willkg deleted the willkg-bug-1888223-links branch March 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants