Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1881632: update circleci remote docker image #2900

Merged
merged 1 commit into from Mar 1, 2024

Conversation

willkg
Copy link
Collaborator

@willkg willkg commented Mar 1, 2024

Previously, we specified an image that's now deprecated. This removes the version specification which will cause it to use the default which is currently docker 24. default will change over time, but we'll know if CI fails pretty quick and we're switching to GCP soon with a completely different deploy pipeline anyhow.

We did this with Socorro:

mozilla-services/socorro#6533

Previously, we specified an image that's now deprecated. This removes
the version specification which will cause it to use the default which
is currently docker 24. default will change over time, but we'll know if
CI fails pretty quick and we're switching to GCP soon with a completely
different deploy pipeline anyhow.
@willkg willkg requested a review from a team as a code owner March 1, 2024 14:12
@willkg
Copy link
Collaborator Author

willkg commented Mar 1, 2024

@relud I looked at Antenna and noticed you fixed this by changing the version to docker24. Should we be doing that instead? If so, I can change this PR and then go update Socorro.

I don't know why I didn't look at Antenna before. I wish I had.

@relud
Copy link
Member

relud commented Mar 1, 2024

i'm in favor of removing the version

@willkg willkg merged commit 1f04d76 into main Mar 1, 2024
1 check passed
@willkg willkg deleted the willkg-bug-1881632-circleci branch March 1, 2024 15:52
@willkg
Copy link
Collaborator Author

willkg commented Mar 1, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants