Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPU architecture type detection from site.js #14404

Open
2 tasks
alexgibson opened this issue Apr 3, 2024 · 3 comments
Open
2 tasks

Remove CPU architecture type detection from site.js #14404

alexgibson opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
Papercuts 💸 Tech debt payoff

Comments

@alexgibson
Copy link
Member

Description

I need to double check first, but I think since #14096 was completed we no longer need to keep the archType UA checks that are still in site.js.


Success Criteria

  • Verify that there's nothing left that relies on detecting CPU type (e.g. ARM).
  • Remove archType functions and code from site.js.
@alexgibson alexgibson self-assigned this Apr 3, 2024
@alexgibson alexgibson added the Papercuts 💸 Tech debt payoff label Apr 3, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 4, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 4, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 4, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 9, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 10, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 17, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 19, 2024
@janbrasna
Copy link
Contributor

There's an open issue for Chromebooks: #8006 that refers (=is caused by?) this sniffing. Can't tell if removal of the arch detection makes the Chromebook results better or worse, just wanted to mention it.

@alexgibson
Copy link
Member Author

alexgibson commented Apr 22, 2024

@janbrasna if removing this code helps fix one of those false positives then it's another reason to simplify 👍

@janbrasna
Copy link
Contributor

Additionally I think the .arm body class added to the /thanks page has no effect today — it used to show a link to sumo, but that's long gone, and today even the linux-arm explainer is removed in favour of generic instructions. Windows ARM64 detection is removed too #9768, so this seems OK.

The ARMv8-A are still tested via getArchSize("aarch64") if needed so this all looks like just an old, unused code. :shipit: 🚢

alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 23, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 30, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 1, 2024
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Papercuts 💸 Tech debt payoff
Projects
None yet
Development

No branches or pull requests

2 participants