Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove archType and isARM() from site.js (Fixes #14404) #14409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove archType and isARM() from site.js (Fixes #14404) #14409

wants to merge 1 commit into from
+1 −179

Conversation

alexgibson
Copy link
Member

One-line summary

We no longer actively use this code since #14012 was completed, so we can remove these functions from site.js.

Issue / Bugzilla link

#14404

Testing

  • Verify that nothing seems to be using either window.site.archType or window.site.isARM().

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Apr 4, 2024
@alexgibson alexgibson force-pushed the remove-arch-type-detection branch 4 times, most recently from 39ba637 to 9935deb Compare April 10, 2024 08:19
@alexgibson alexgibson force-pushed the remove-arch-type-detection branch 3 times, most recently from ea57bd7 to 23ca20a Compare April 23, 2024 14:47
@alexgibson alexgibson force-pushed the remove-arch-type-detection branch 2 times, most recently from 55fe891 to 61bdca5 Compare May 1, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review Awaiting code review P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alexgibson