Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referral tags to home & account product links #14478

Merged
merged 2 commits into from Apr 29, 2024

Conversation

janbrasna
Copy link
Contributor

One-line summary

Adds most prominent missing utm_params to products / own external links.

Significant changes and points to review

  • This is just the low-hanging fruit for add UTM codes for links to monitor.mozilla.org #14432 with most impact, will look around some more for less prominent locations eventually, too.
  • Also removes some passé branding switches, leaving that to ftl fallbacks now.
  • Removes some /account ftl conditional logic that mostly doesn't work, when at it.

Issue / Bugzilla link

#14432

Testing

http://localhost:8000/en-GB/
http://localhost:8000/en-GB/account/

Copy link
Contributor Author

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes for reviewer:

bedrock/mozorg/templates/mozorg/account.html Show resolved Hide resolved
bedrock/mozorg/templates/mozorg/account.html Show resolved Hide resolved
Comment on lines 11 to +12
{% set _entrypoint = 'mozilla.org-firefox-accounts' %}
{% set referrals = '?utm_source=www.mozilla.org&utm_medium=referral&utm_campaign=account' %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the utm_tags use _entrypoint values, but here the location is no longer valid (/firefox/accounts moved to /accounts) so I'm using params independent on it.

At the same time I'm not updating the _entrypoint value so the data collected stays consistent even when it doesn't reflect the right location today.

@janbrasna janbrasna changed the title Add referral tags to home and account Add referral tags to home & account product links Apr 26, 2024
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ thanks!

@alexgibson alexgibson merged commit 98fe969 into mozilla:main Apr 29, 2024
3 checks passed
@janbrasna janbrasna deleted the upd/monitor-tags branch May 1, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants