Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mozilla_monitor conditionals (Fixes #14493) #14534

Merged
merged 2 commits into from May 3, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented May 1, 2024

One-line summary

Removed the conditional since Mozilla Monitor has been out for quite some time now, and it's time to retire any of the old and obsolete Firefox Monitor strings and references.

Sibling PR for switch: mozmeao/www-config#560

Significant changes and points to review

  • Removed conditionals from relevant HTML files
  • Removed obsolete Firefox Monitor strings from relative Fluent files

Issue / Bugzilla link

Fixes #14492
Supersedes #14493

Testing

@alexgibson
Copy link
Member Author

Note that this PR is still missing some changes from the original PR that will need manually adding here, as they were accidentally squashed into a commit from another PR.

@reemhamz
Copy link
Contributor

reemhamz commented May 2, 2024

Thanks so much Alex!! You're a git-king 👑 I pushed some changes that should cover the missing files. Let me know if I missed anything.

@alexgibson
Copy link
Member Author

I took a look through the updates and they look OK to me - but I can't approve the PR since I opened it. Perhaps either @craigcook or @stephaniehobson can do the honors?

I'm really glad you managed to save things OK!

@reemhamz
Copy link
Contributor

reemhamz commented May 3, 2024

Spoke w/ Alex and agreed that since he approved these same changes in the previous PR, then this is okay for me to approve and merge 👍🏼 Thanks again Alex!

@reemhamz reemhamz merged commit eb92898 into mozilla:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Mozilla Monitor conditionals
2 participants