New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create telemetry.active_users view #5247
Open
lucia-vargas-a
wants to merge
72
commits into
main
Choose a base branch
from
DENG-3127_create_active_users_view
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+144
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lucia-vargas-a
commented
Mar 20, 2024
bochocki
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I think there are just a few simple changes required to get this merged.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bochocki
reviewed
Mar 21, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bochocki
reviewed
Mar 25, 2024
bochocki
reviewed
Mar 25, 2024
This comment has been minimized.
This comment has been minimized.
This reverts commit c2ab9b0.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Create clients_last_seen_v2 checks. * Formatting. --------- Co-authored-by: Brad Ochocki Szasz <brad.ochocki@gmail.com>
* DENG-3008 removing misspelled file * DENG-3008 adding suppressions model * adding products model * updating dataset * adding newsletter model * adding waitlist model * removing create statement and adding modified timestamp * updating name and description for newsletters * updating description * adding users model * adding braze dag * changing subscribed to boolean * updating type to date * updating to full refresh * updating email id to external id for standardization * updating format * updating nullable fields * updating format * updating nullable fields * adding subscription map model * adding subscriptions model * adding user profiles model * updating format * formatting * removing last modified date in favor of only timestamp * updating table name
* fix: GLAM checks to prevent skipping days of data * format sql * Skip dryrun
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@lucia-vargas-a is most of this logic going to live in the |
Integration report for "Get columns from Desktop's clients_last_seen_v2 and Mobile's baseline_clients_last_seen views."
|
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements view for all apps to return user active status, mainly dau, wau, mau.
DENG-2975
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):