New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial add of query.sql WIP for ga downloads_with_attr_v3 #5397
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would simplify the group by and exclude empty strings/ (not set) but besides that LGTM
…E after calculation CTE
…rsion, normalized_country_code
Integration report for "add in normalized_os, normalized_browser, normalized_browser_major_version, normalized_country_code"
|
I reviewed, left some notes. Supplementary materials here: Downloads with Attribution V3 Review Doc Actually, I would step back and think about what you want this table to be. I think we discussed it a bit last time. To me, there’s two choices: |
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task