feat: add is_init() to glean_usage queries #5509
Draft
+138
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
scholtzan
reviewed
May 7, 2024
Comment on lines
+6
to
+11
| SELECT | ||
| * | ||
| FROM | ||
| `{{ project_id }}.{{ app_name }}.metrics_clients_daily` AS m | ||
| WHERE | ||
| FALSE |
There was a problem hiding this comment.
We need to get the right metrics fields here:
Suggested change
| SELECT | |
| * | |
| FROM | |
| `{{ project_id }}.{{ app_name }}.metrics_clients_daily` AS m | |
| WHERE | |
| FALSE | |
| SELECT | |
| DATE(@submission_date) AS submission_date, | |
| _current.client_id, | |
| _current.sample_id, | |
| _current.normalized_channel, | |
| _current.n_metrics_ping, | |
| _current.days_sent_metrics_ping_bits AS days_sent_metrics_ping_bits, | |
| {% if app_name in metrics -%} | |
| {% for metric in metrics[app_name] -%} | |
| _current.{{metric}} AS {{metric}}, | |
| {% endfor -%} | |
| {% endif -%} | |
| FROM | |
| `{{ project_id }}.{{ app_name }}.metrics_clients_daily` AS _current | |
| WHERE FALSE |
Integration report for "Merge branch 'main' into feat/add_is_init-to-glean_usage-queries"
|
sean-rose
reviewed
May 8, 2024
There was a problem hiding this comment.
The changes to this view and some of the changes to clients_last_seen_joined.query.sql seem like they're unrelated to the purpose of adding is_init(), and are kind of bleeding over from #5434. I'd suggest removing these unrelated changes.
Comment on lines
+3
to
+5
| {% raw %} | ||
| {% if is_init() %} | ||
| {% endraw %} |
There was a problem hiding this comment.
For consistency (e.g. you specifically changed baseline_clients_last_seen_v1.query.sql to switch to this single-line format).
Suggested change
| {% raw %} | |
| {% if is_init() %} | |
| {% endraw %} | |
| {% raw %}{% if is_init() %}{% endraw %} |
(ditto for the {% else %} and {% endif %} parts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for reviewer:
<username>:<branch>of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-forkCI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS):┆Issue is synchronized with this Jira Task