Add checks for DAU increased by more than 50% versus previous date. #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This comment has been minimized.
This comment has been minimized.
kwindau
approved these changes
May 10, 2024
bochocki
approved these changes
May 10, 2024
| @@ -57,3 +57,33 @@ SELECT | |||
| ), | |||
| NULL | |||
| ); | |||
|
|
|||
| {% raw -%} | |||
There was a problem hiding this comment.
Is this raw in the correct place? I'm not familiar with it's use, it it seems different from the other files.
There was a problem hiding this comment.
In this case raw is used to indicate that the text between this and the corresponding end block should not be modified by jinja when generating the output of this template. We have to do this in some cases, for example in this case we generate another jinja template so we want to preserve some of the template features like:
`{{ project_id }}.{{ dataset_id }}.{{ table_name }}`
|
@lucia-vargas-a you may have not see this change. A change has been added to My question, if we're trying to check for duplication should we use the |
Thanks for the link. This checks are more oriented towards avoiding overcounting when joining the baseline and metrics ping. I think we could use |
Integration report for "Merge branch 'main' into DENG-2989_checks_for_possible_duplicates"
|
lelilia
reviewed
May 13, 2024
| ) | ||
| SELECT | ||
| IF( | ||
| ABS((SELECT SUM(dau) FROM dau_current) / (SELECT SUM(dau) FROM dau_previous)) > 1.5, |
There was a problem hiding this comment.
Not sure why you would need the ABS here?
But if it's to account for the unlikely case of negative DAU (?) what about securing against dividing by zero?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks for DAU increased by more than 50% vs. previous date which could indicate duplicates.
Address the review comment in PR-5396 related to the join of baseline or main ping and metrics ping in active_users_aggregates.
Checklist for reviewer:
<username>:<branch>of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-forkCI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS):┆Issue is synchronized with this Jira Task