This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Bug 709349 - Getting broken pipe running talos in --develop mode #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The branch name is misspelled as 703349 though the commit log is correct. Should I fix that? |
|
Sorry, I didn't realize this was outstanding. Is there anything actionable here? |
|
@k0s not sure. https://bugzilla.mozilla.org/show_bug.cgi?id=709349#c30 says it is already in production. May be you can simply close this one? |
|
It looks like it. Thanks for the detective work, @BYK |
|
@k0s Always a pleasure ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version got an r+ from @wlach which included some unwanted code style changes. This one shouldn't be having them and should be OK for merging.