Skip to content

Commit

Permalink
Tests for dynamic regexes will now run during 'check-stage2'.
Browse files Browse the repository at this point in the history
Before, tests for dynamic regexes ran during stage1 and tests for
native regexes ran during stage2. But the buildbots don't test stage1,
so now both dynamic and native tests are run during stage2.

Closes #13740.
  • Loading branch information
BurntSushi committed Apr 25, 2014
1 parent 6c3bdbe commit 34c88ef
Showing 1 changed file with 15 additions and 5 deletions.
20 changes: 15 additions & 5 deletions src/libregex/test/mod.rs
Expand Up @@ -12,9 +12,17 @@
#[phase(syntax)]
extern crate regex_macros;

// Dirty hack: During stage1, test dynamic regexs. For stage2, we test
// native regexs.
#[cfg(stage1)]
#[cfg(not(stage1))]
#[path = "bench.rs"]
mod native_bench;

#[cfg(not(stage1))]
#[path = "tests.rs"]
mod native_tests;

// Due to macro scoping rules, this definition only applies for the modules
// defined below. Effectively, it allows us to use the same tests for both
// native and dynamic regexes.
macro_rules! regex(
($re:expr) => (
match ::regex::Regex::new($re) {
Expand All @@ -24,6 +32,8 @@ macro_rules! regex(
);
)

mod bench;
mod tests;
#[path = "bench.rs"]
mod dynamic_bench;
#[path = "tests.rs"]
mod dynamic_tests;

5 comments on commit 34c88ef

@bors
Copy link
Contributor

@bors bors commented on 34c88ef Apr 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at BurntSushi@34c88ef

@bors
Copy link
Contributor

@bors bors commented on 34c88ef Apr 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging BurntSushi/rust/regex-dynamic-tests = 34c88ef into auto

@bors
Copy link
Contributor

@bors bors commented on 34c88ef Apr 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BurntSushi/rust/regex-dynamic-tests = 34c88ef merged ok, testing candidate = a692e9b

@bors
Copy link
Contributor

@bors bors commented on 34c88ef Apr 26, 2014

@bors
Copy link
Contributor

@bors bors commented on 34c88ef Apr 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = a692e9b

Please sign in to comment.