Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yet-to-be-merged libregex is not testing dynamic regexps #13740

Closed
BurntSushi opened this issue Apr 25, 2014 · 0 comments · Fixed by #13766
Closed

yet-to-be-merged libregex is not testing dynamic regexps #13740

BurntSushi opened this issue Apr 25, 2014 · 0 comments · Fixed by #13766

Comments

@BurntSushi
Copy link
Member

I previously relied on an abuse of bootstrapping to test dynamic regexps during stage1 and native regexps during stage2, but it turns out stage1 tests aren't run by the bots. Since dynamic and native regexps use different code, it's imperative that both are tested.

I have a fix coming soon that will push dynamic and native regexp testing into stage2.
BurntSushi added a commit to BurntSushi/rust that referenced this issue Apr 25, 2014
@BurntSushi
Tests for dynamic regexes will now run during 'check-stage2'.
34c88ef 
Before, tests for dynamic regexes ran during stage1 and tests for
native regexes ran during stage2. But the buildbots don't test stage1,
so now both dynamic and native tests are run during stage2.

Closes rust-lang#13740.
@BurntSushi BurntSushi mentioned this issue Apr 25, 2014
Merged
bors added a commit that referenced this issue Apr 26, 2014
@bors
auto merge of #13766 : BurntSushi/rust/regex-dynamic-tests, r=alexcri…
a692e9b 
…chton

Before, tests for dynamic regexes ran during stage1 and tests for
native regexes ran during stage2. But the buildbots don't test stage1,
so now both dynamic and native tests are run during stage2.

Closes #13740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests for dynamic regexes will now run during 'check-stage2'. BurntSushi/rust
1 participant
@BurntSushi