Skip to content

Commit

Permalink
Changed tidy script to remove restriction on FIXME and to warn agains…
Browse files Browse the repository at this point in the history
…t XXX instead
  • Loading branch information
salemtalha committed Jan 26, 2014
1 parent cc61fc0 commit 40df08a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/etc/tidy.py
Expand Up @@ -45,9 +45,8 @@ def do_license_check(name, contents):
openhook=fileinput.hook_encoded("utf-8")):

if fileinput.filename().find("tidy.py") == -1:
if line.find("FIXME") != -1:
if re.search("FIXME.*#\d+", line) == None:
report_err("FIXME without issue number")
if line.find("// XXX") != -1:
report_err("XXX is no longer necessary, use FIXME")
if line.find("TODO") != -1:
report_err("TODO is deprecated; use FIXME")
match = re.match(r'^.*//\s*(NOTE.*)$', line)
Expand Down

5 comments on commit 40df08a

@bors
Copy link
Contributor

@bors bors commented on 40df08a Jan 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from brson
at salemtalha@40df08a

@bors
Copy link
Contributor

@bors bors commented on 40df08a Jan 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging salemtalha/rust/master = 40df08a into auto

@bors
Copy link
Contributor

@bors bors commented on 40df08a Jan 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

salemtalha/rust/master = 40df08a merged ok, testing candidate = d3f70f5

@bors
Copy link
Contributor

@bors bors commented on 40df08a Jan 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 40df08a Jan 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = d3f70f5

Please sign in to comment.