Skip to content

Commit

Permalink
Changed tidy script to remove restriction on FIXME and to warn agains…
Browse files Browse the repository at this point in the history
…t XXX instead
  • Loading branch information
salemtalha committed Jan 26, 2014
1 parent cc61fc0 commit 40df08a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/etc/tidy.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@ def do_license_check(name, contents):
openhook=fileinput.hook_encoded("utf-8")):

if fileinput.filename().find("tidy.py") == -1:
if line.find("FIXME") != -1:
if re.search("FIXME.*#\d+", line) == None:
report_err("FIXME without issue number")
if line.find("// XXX") != -1:
report_err("XXX is no longer necessary, use FIXME")
if line.find("TODO") != -1:
report_err("TODO is deprecated; use FIXME")
match = re.match(r'^.*//\s*(NOTE.*)$', line)
Expand Down

0 comments on commit 40df08a

Please sign in to comment.