-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Directly construct lvalue datums for function arguments
The current split between create_datums_for_fn_args, copy_args_to_allocas and store_arg involves a detour via rvalue datums which cause additional work in form of insertvalue/extractvalue pairs for fat pointer arguments, and an extra alloca and memcpy for tupled args in rust-call functions. By merging those three functions into just one that actually covers the whole process of creating the final argument datums, we can skip all that. Also, this allows to easily merge in the handling of rust-call functions, allowing to make create_datum_for_fn_args_under_call_abi obsolete. cc #26600 -- The insertvalue instructions kicked us off of fast-isel.
- Loading branch information
Showing
3 changed files
with
101 additions
and
162 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters