Skip to content

Commit

Permalink
Only emit save-analysis data for cargo build tasks
Browse files Browse the repository at this point in the history
Previously, we were emittinng analysis data for all tasks, including `doc`. That meant we got two sets of save-analysis data, one from the normal build and one from the docs. That means indexing with the RLS took twice as long and made downloads larger and build times longer.

cc rust-lang/rls#826
  • Loading branch information
nrc committed Apr 17, 2018
1 parent 6b12d36 commit de34735
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/bootstrap/builder.rs
Expand Up @@ -756,7 +756,9 @@ impl<'a> Builder<'a> {
}
}

if mode == Mode::Libstd && self.config.extended && compiler.is_final_stage(self) {
if cmd == "build" && mode == Mode::Libstd
&& self.config.extended && compiler.is_final_stage(self)
{
cargo.env("RUSTC_SAVE_ANALYSIS", "api".to_string());
}

Expand Down

0 comments on commit de34735

Please sign in to comment.