Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Put std lib analysis data in per-target directories #826

Closed
nrc opened this issue Apr 15, 2018 · 1 comment
Closed

Put std lib analysis data in per-target directories #826

nrc opened this issue Apr 15, 2018 · 1 comment
Labels
Milestone

Comments

@nrc
Copy link
Member

nrc commented Apr 15, 2018

This is probably a Rustbuild/Rustup/rls-analysis issue, but tracking here because I don't know exactly where to fix it.

If a user has multiple toolchains installed with rustup, then they will get multiple sets of analysis data (the JSON files) for the std libs, one per target (I think). These get installed into the same directory (e.g., /Users/nick/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/analysis). That means that indexing takes twice as long as it should and there is duplicate data (though I think rls-analysis will not duplicate, it might do some kind of bad merge).

@nrc nrc added the P-high label Apr 15, 2018
@nrc nrc added this to the 1.0 milestone Apr 15, 2018
@nrc
Copy link
Member Author

nrc commented Apr 17, 2018

This is not a rustup issue like I thought, but that Rustbuild is making two copies of the analysis data for at least some toolchains.

nrc added a commit to nrc/rust that referenced this issue Apr 17, 2018
Previously, we were emittinng analysis data for all tasks, including `doc`. That meant we got two sets of save-analysis data, one from the normal build and one from the docs. That means indexing with the RLS took twice as long and made downloads larger and build times longer.

cc rust-lang/rls#826
bors added a commit to rust-lang/rust that referenced this issue Apr 18, 2018
Only emit save-analysis data for `cargo build` tasks

Previously, we were emittinng analysis data for all tasks, including `doc`. That meant we got two sets of save-analysis data, one from the normal build and one from the docs. That means indexing with the RLS took twice as long and made downloads larger and build times longer.

cc rust-lang/rls#826

r? @Mark-Simulacrum
@nrc nrc closed this as completed May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant