Trim header values in GetResponseHeader

Fixes #24917
servo · Nov 30, 2019 · a91176e · a91176e
1 parent f9c69e8
commit a91176e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/components/script/dom/xmlhttprequest.rs b/components/script/dom/xmlhttprequest.rs
@@ -783,8 +783,10 @@ impl XMLHttpRequestMethods for XMLHttpRequest {
             if !first {
                 vec.extend(", ".as_bytes());
             }
-            first = false;
-            vec.extend(value.as_bytes());
+            if let Ok(v) = str::from_utf8(value.as_bytes()).map(|s| s.trim().as_bytes()) {
+                vec.extend(v);
+                first = false;
+            }
             vec
         });
 

diff --git a/tests/wpt/metadata/xhr/headers-normalize-response.htm.ini b/tests/wpt/metadata/xhr/headers-normalize-response.htm.ini
@@ -6,15 +6,3 @@
   [Header value: \\0hello_world]
     expected: FAIL
 
-  [Header value: hello_world[tab\]]
-    expected: FAIL
-
-  [Header value: [tab\]hello_world[tab\]]
-    expected: FAIL
-
-  [Header value: hello_world__]
-    expected: FAIL
-
-  [Header value: __hello_world__]
-    expected: FAIL
-