Merge pull request #3538 from diox/only-admins-can-submit-updates

Remove links to submit new versions of apps for non-admins (bug 1299565)
mozilla · Sep 13, 2016 · 203f2e8 · 203f2e8
2 parents 5a756c5 + d28167e
commit 203f2e8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/mkt/developers/templates/developers/apps/listing/item_actions_app.html b/mkt/developers/templates/developers/apps/listing/item_actions_app.html
@@ -39,14 +39,6 @@ <h5>{{ _('Actions') }}</h5>
     </li>
   {% endif %}
 
-  {% if addon.is_packaged %}
-    <li>
-      <a href="{{ addon.get_dev_url('versions') }}" class="action-link tooltip"
-         title="{{ _('Add a new version of the packaged app.') }}">
-        {{ _('Add New Version') }}</a>
-    </li>
-  {% endif %}
-
   <li>
     <a class="action-link status-link" href="{{ addon.get_dev_url('versions') }}">
       {{ _('Status &amp; Versions') if addon.is_packaged else _('Status') }}</a>

diff --git a/mkt/developers/templates/developers/apps/status.html b/mkt/developers/templates/developers/apps/status.html
@@ -245,6 +245,7 @@ <h2>{{ _('Packaged Versions') }}</h2>
         </section>
       {% endif %}
 
+      {% if is_admin %}
       <h2 id="upload-new-version">{{ _('Upload New Version') }}</h2>
       <section>
         <div class="island">
@@ -280,6 +281,7 @@ <h2 id="upload-new-version">{{ _('Upload New Version') }}</h2>
           </form>
         </div>
       </section>
+      {% endif %}
     {% endif %}
 
     {% if is_tarako %}

diff --git a/mkt/developers/tests/test_views.py b/mkt/developers/tests/test_views.py
@@ -176,7 +176,6 @@ def test_action_links(self):
         doc = pq(self.client.get(self.url).content)
         expected = [
             ('Edit Listing', app.get_dev_url()),
-            ('Add New Version', app.get_dev_url('versions')),
             ('Status & Versions', app.get_dev_url('versions')),
             ('Content Ratings', app.get_dev_url('ratings')),
             ('Team Members', app.get_dev_url('owner')),